Skip to content

cann: Fix ggml_cann_im2col for 1D im2col #8819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

MengqingCao
Copy link
Contributor

  1. Fix ggml_cann_im2col op for performing 1D im2col
  2. Add related test cases

Test results:
image

@github-actions github-actions bot added the testing Everything test related label Aug 2, 2024
@hipudding
Copy link
Collaborator

fix all compile warnings.

@hipudding hipudding added the Ascend NPU issues specific to Ascend NPUs label Aug 2, 2024
@hipudding hipudding changed the title Fix ggml_cann_im2col for 1D im2col cann: Fix ggml_cann_im2col for 1D im2col Aug 2, 2024
@MengqingCao
Copy link
Contributor Author

fix all compile warnings.

done

@hipudding hipudding merged commit e09a800 into ggml-org:master Aug 2, 2024
53 checks passed
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Aug 7, 2024
* fix ggml_cann_im2col for 1D im2col

* fix build warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ascend NPU issues specific to Ascend NPUs testing Everything test related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants