Skip to content

Include original resolver name in migrated Secret Scanning alerts #1334

Open
@theztefan

Description

@theztefan

Description

When using the gh gei migrate-secret-alerts to migrate alerts, the resolution comments from the source alert are also mapped over to the target alerts. Which works fine but can be further improved to include the original resolver name into the comment. The reason for this is because typicall the gh gei migrate-secret-alerts in migrations is run with tokens generated by GitHub Apps therefore the resolver in the target alert is a tool therefore we are losing the useful information of who originally closed an alert.

Example

Source alert resolution comment:

Image

After migrating it with a workflow that uses GitHub App to generate tokens, the target alert does not show @theztefan as closer by rather ghas-control[bot].

Image

Proposed improvement

This result expected and not a bug! The suggestion is to also transfer the resolver name as part of the comment in the target alert. So the result in the example above would be ghas-control[bot] closed this with a comment @theztefan: Revoked today.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions