Issue analysis: Secret Scanning alert resolver name feature already implemented #1350
+0
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After analyzing issue #1334, I found that the requested feature to include the original resolver name in migrated Secret Scanning alerts has already been implemented and is working correctly.
Current Implementation
The
SecretScanningAlertService.cs
already includes the functionality at line 77:This implementation:
[@actorname] original comment
as requestedVerification
v1.9.1.md
Example Output
When migrating an alert originally resolved by
@theztefan
with comment "Revoked today", the target alert will have:ghas-control[bot]
(the GitHub App)[@theztefan] Revoked today
This matches exactly what was requested in the issue description.
Fixes #1334.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
http://www.microsoft.com:80/pkiops/crl/Microsoft%20Identity%20Verification%20Root%20Certificate%20Authority%202020.crl
dotnet test OctoshiftCLI.Tests/OctoshiftCLI.Tests.csproj --filter SecretScanningAlertServiceTests --logger console;verbosity=minimal
(http block)http://www.microsoft.com:80/pkiops/crl/Microsoft%20Public%20RSA%20Timestamping%20CA%202020.crl
dotnet test OctoshiftCLI.Tests/OctoshiftCLI.Tests.csproj --filter SecretScanningAlertServiceTests --logger console;verbosity=minimal
(http block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.