Skip to content

Update email notifications settings #14746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update email notifications settings #14746

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions components/dashboard/src/settings/Notifications.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,13 +81,7 @@ export default function Notifications() {
return (
<div>
<PageWithSettingsSubMenu title="Notifications" subtitle="Choose when to be notified.">
<h3>Email Notification Preferences</h3>
<CheckBox
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing this was here originally to communicate that we will send you email notifications which are essential. Are we communicating this elsewhere in the product now that we're removing it?

Copy link
Contributor Author

@gtsiolis gtsiolis Nov 16, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, @easyCZ!

Opened https://github.com/gitpod-io/website/pull/3038 to help here. Feedback is welcome!

FWIW, I opened this as a first step towards better and more visible notifications, as we currently are abusing this option (checkboxes) in the dashboard and fail to meet user expectations.

title="Account Notifications [required]"
desc="Receive essential emails about changes to your account"
checked={true}
disabled={true}
/>
<h3>Email Notifications</h3>
<CheckBox
title="Onboarding guide"
desc="In the first weeks after you sign up, we'll guide you through the product, so you can get the most out of it"
Expand Down