Skip to content

Update email notifications settings #14746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

gtsiolis
Copy link
Contributor

@gtsiolis gtsiolis commented Nov 16, 2022

Description

Remove the always disabled option for account notifications.

How to test

  1. Create an account
  2. Go to notifications settings
  3. Notice the disabled account notifications option is missing

Screenshots

BEFORE AFTER
notifications-before notifications-after

Release Notes

Update email notifications settings

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@gtsiolis gtsiolis requested a review from a team November 16, 2022 14:10
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Nov 16, 2022
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-gt-update-notifications-settings.1 because the annotations in the pull request description changed
(with .werft/ from main)

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-gt-update-notifications-settings.2 because the annotations in the pull request description changed
(with .werft/ from main)

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-gt-update-notifications-settings.3 because the annotations in the pull request description changed
(with .werft/ from main)

@@ -81,13 +81,7 @@ export default function Notifications() {
return (
<div>
<PageWithSettingsSubMenu title="Notifications" subtitle="Choose when to be notified.">
<h3>Email Notification Preferences</h3>
<CheckBox
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing this was here originally to communicate that we will send you email notifications which are essential. Are we communicating this elsewhere in the product now that we're removing it?

Copy link
Contributor Author

@gtsiolis gtsiolis Nov 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, @easyCZ!

Opened https://github.com/gitpod-io/website/pull/3038 to help here. Feedback is welcome!

FWIW, I opened this as a first step towards better and more visible notifications, as we currently are abusing this option (checkboxes) in the dashboard and fail to meet user expectations.

@geropl
Copy link
Member

geropl commented Nov 18, 2022

@gtsiolis Could you provide some context to the change? Or ask someone with that context to review the PR? I'm aware we had discussions lately, but I'm struggling to understand what our approach is, and how this change helps with those efforts. 🙏

@stale
Copy link

stale bot commented Dec 3, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Dec 3, 2022
@easyCZ
Copy link
Member

easyCZ commented Dec 9, 2022

Moving to draft as currently the conversation has gone stale, but it continues to show up in review requests. Please move back to in review once actionable.

@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label Dec 9, 2022
@easyCZ easyCZ marked this pull request as draft December 9, 2022 13:38
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Dec 9, 2022

Thanks for changing this to draft[1], @easyCZ!

@geropl Regarding #14746 (comment), all the context is linked in the description of the corresponding PR in https://github.com/gitpod-io/website/pull/3038. See also relevant RFC (internal).🤓

Let me know if this helps, otherwise bringing this up to the WebApp team weekly sync could help. 🏓

For more context, this PR is a step towards improving the current state of the mixed and confusing situation on user expectations regarding the emails they are getting and triggering negative feedback about the emails they are getting, see relevant discussion (internal). 👣

If 🅰️ the changes in this PR do not not like something we'd like to merge or 🅱️ it's not obvious that having an always disabled checkbox is not good UX, let's close the PR. 💭

@stale
Copy link

stale bot commented Dec 20, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Dec 20, 2022
@stale stale bot closed this Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress meta: stale This issue/PR is stale and will be closed soon release-note size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants