-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Update email notifications settings #14746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
started the job as gitpod-build-gt-update-notifications-settings.1 because the annotations in the pull request description changed |
started the job as gitpod-build-gt-update-notifications-settings.2 because the annotations in the pull request description changed |
started the job as gitpod-build-gt-update-notifications-settings.3 because the annotations in the pull request description changed |
@@ -81,13 +81,7 @@ export default function Notifications() { | |||
return ( | |||
<div> | |||
<PageWithSettingsSubMenu title="Notifications" subtitle="Choose when to be notified."> | |||
<h3>Email Notification Preferences</h3> | |||
<CheckBox |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing this was here originally to communicate that we will send you email notifications which are essential. Are we communicating this elsewhere in the product now that we're removing it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, @easyCZ!
Opened https://github.com/gitpod-io/website/pull/3038 to help here. Feedback is welcome!
FWIW, I opened this as a first step towards better and more visible notifications, as we currently are abusing this option (checkboxes) in the dashboard and fail to meet user expectations.
@gtsiolis Could you provide some context to the change? Or ask someone with that context to review the PR? I'm aware we had discussions lately, but I'm struggling to understand what our approach is, and how this change helps with those efforts. 🙏 |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Moving to draft as currently the conversation has gone stale, but it continues to show up in review requests. Please move back to in review once actionable. |
Thanks for changing this to draft[1], @easyCZ! @geropl Regarding #14746 (comment), all the context is linked in the description of the corresponding PR in https://github.com/gitpod-io/website/pull/3038. See also relevant RFC (internal).🤓 Let me know if this helps, otherwise bringing this up to the WebApp team weekly sync could help. 🏓 For more context, this PR is a step towards improving the current state of the mixed and confusing situation on user expectations regarding the emails they are getting and triggering negative feedback about the emails they are getting, see relevant discussion (internal). 👣 If |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Description
Remove the always disabled option for account notifications.
How to test
Screenshots
Release Notes
Werft options:
If enabled this will build
install/preview
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh