Remove disabled checkbox for account notifications

[gtsiolis]

Description

Reviving #14746.

Cross-posting relevant comment in #14746 (comment).

See also relevant RFC (internal). Cc @chrifro @taliamoyal

Changes summary and walkthrough generated by Copilot

How to test

Go to /notifications and notice there's no longer a disabled checkbox for the account notifications.

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

• 🏷️ Name - gt-remove-e8c87586ba
• 🔗 URL - gt-remove-e8c87586ba.preview.gitpod-dev.com/workspaces.
• 📚 Documentation - See our internal documentation for information on how to interact with your preview environment.
• 📦 Version - gt-remove-account-notifications-gha.13984

Build Options

Build

• /werft with-werft
  Run the build with werft instead of GHA
• leeway-no-cache
• /werft no-test
  Run Leeway with --dont-test

Publish

• /werft publish-to-npm
• /werft publish-to-jb-marketplace

Installer

• analytics=segment
• with-dedicated-emulation
• workspace-feature-flags
  Add desired feature flags to the end of the line above, space separated

Preview Environment

• /werft with-local-preview
  If enabled this will build install/preview
• /werft with-preview
• /werft with-large-vm
• /werft with-gce-vm
  If enabled this will create the environment on GCE infra
• with-integration-tests=all
  Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh
• with-monitoring

/hold

[mustard-mh]

@gtsiolis Actually I can't enable other checkboxes on this page too, is it known? (Found it years ago, but just forgot to mention)

[gtsiolis]

@mustard-mh I could check or uncheck all other checkboxes there. Usually it takes a while to reflect the changes, not sure why. Maybe because of this, it takes a while to make the checkbox feel reactive? Could you try to check or uncheck something and wait a bit?

[mustard-mh]

@mustard-mh I could check or uncheck all other checkboxes there. Usually it takes a while to reflect the changes, not sure why. Maybe because of this, it takes a while to make the checkbox feel reactive? Could you try to check or uncheck something and wait a bit?

@gtsiolis I see, it's because my additionData don't have emailNotificationSettings property, so it will not work for me.

Maybe there're lots of users affected, going to create an issue. I remember that @iQQBot is the same

[mustard-mh]

Code LGTM

[gtsiolis]

Thanks @mustard-mh for taking a look, and taking a bias for action by opening EXP-288. 🏓

/unhold