-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Update button and navigation styles #16433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/werft run with-preview=true 👍 started the job as gitpod-build-gt-update-primary-button-color.1 |
ca8a85d
to
159199d
Compare
159199d
to
4f156b3
Compare
Ready-For-Review 🏓 /werft run with-preview=true 👍 started the job as gitpod-build-gt-update-primary-button-color.4 |
/werft run with-clean-slate-deployment=true with-preview=true recreate-vm=true 👍 started the job as gitpod-build-gt-update-primary-button-color.5 |
started the job as gitpod-build-gt-update-primary-button-color.6 because the annotations in the pull request description changed |
started the job as gitpod-build-gt-update-primary-button-color.7 because the annotations in the pull request description changed |
/werft run with-clean-slate-deployment=true with-preview=true recreate-vm=true 👍 started the job as gitpod-build-gt-update-primary-button-color.8 |
4f156b3
to
68b1941
Compare
/werft run with-clean-slate-deployment=true with-preview=true recreate-vm=true 👍 started the job as gitpod-build-gt-update-primary-button-color.10 |
@gtsiolis Although I saw the internal discussion, I'm not sure everybody is aligned yet. Also, I feel product should ultimately decide. |
DEAL—Let's hold this for now until consensus is reached. Thanks for the nudge, @geropl. Cross-posting relevant discussion (internal) for visibility. /hold |
68b1941
to
2b01cdf
Compare
/werft run with-clean-slate-deployment=true with-preview=true recreate-vm=true 👍 started the job as gitpod-build-gt-update-primary-button-color.12 |
2b01cdf
to
2b7119c
Compare
2b7119c
to
7f7df17
Compare
Marking this as draft to fine tune and remove it from the GH notifications in Slack. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
7f7df17
to
047cb54
Compare
Description
Style updates for the primary button, see relevant discussion (internal).
How to test
Navigate through the dashboard and notice how the new button looks and feels alongside with the toned down top navigation. Notice how there's always only one CTA (call-to-action) per context with the strongest visual emphasis.
Release Notes
Documentation
Build Options:
Experimental feature to run the build with GitHub Actions (and not in Werft).
leeway-target=components:all
Run Leeway with
--dont-test
Publish Options
Installer Options
Add desired feature flags to the end of the line above, space separated
Preview Environment Options:
If enabled this will build
install/preview
If enabled this will create the environment on GCE infra
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh