Skip to content

Update button and navigation styles #16433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

gtsiolis
Copy link
Contributor

@gtsiolis gtsiolis commented Feb 16, 2023

Description

Style updates for the primary button, see relevant discussion (internal).

How to test

Navigate through the dashboard and notice how the new button looks and feels alongside with the toned down top navigation. Notice how there's always only one CTA (call-to-action) per context with the strongest visual emphasis.

BEFORE AFTER
Screenshot 2023-02-16 at 17 38 40 Screenshot 2023-02-16 at 17 38 32
Screenshot 2023-02-16 at 17 37 51 (2) Screenshot 2023-02-16 at 17 38 00 (2)
Screenshot 2023-02-16 at 17 36 54 (2) Screenshot 2023-02-16 at 17 38 10 (2)

Release Notes

Update button and navigation styles

Documentation

Build Options:

  • /werft with-github-actions
    Experimental feature to run the build with GitHub Actions (and not in Werft).
  • leeway-no-cache
    leeway-target=components:all
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-ee-license
  • with-slow-database
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Feb 16, 2023

/werft run with-preview=true

👍 started the job as gitpod-build-gt-update-primary-button-color.1
(with .werft/ from main)

@gtsiolis gtsiolis force-pushed the gt/update-primary-button-color branch from ca8a85d to 159199d Compare February 16, 2023 15:33
@roboquat roboquat added size/S and removed size/XS labels Feb 16, 2023
@gtsiolis gtsiolis marked this pull request as ready for review February 16, 2023 15:49
@gtsiolis gtsiolis requested a review from a team February 16, 2023 15:49
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Feb 16, 2023
@gtsiolis gtsiolis force-pushed the gt/update-primary-button-color branch from 159199d to 4f156b3 Compare February 16, 2023 15:52
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Feb 16, 2023

Ready-For-Review 🏓

/werft run with-preview=true

👍 started the job as gitpod-build-gt-update-primary-button-color.4
(with .werft/ from main)

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Feb 16, 2023

/werft run with-clean-slate-deployment=true with-preview=true recreate-vm=true

👍 started the job as gitpod-build-gt-update-primary-button-color.5
(with .werft/ from main)

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-gt-update-primary-button-color.6 because the annotations in the pull request description changed
(with .werft/ from main)

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-gt-update-primary-button-color.7 because the annotations in the pull request description changed
(with .werft/ from main)

@gtsiolis gtsiolis changed the title Update primary button color and corner radius Update button and navigation styles Feb 16, 2023
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Feb 16, 2023

/werft run with-clean-slate-deployment=true with-preview=true recreate-vm=true

👍 started the job as gitpod-build-gt-update-primary-button-color.8
(with .werft/ from main)

@gtsiolis gtsiolis force-pushed the gt/update-primary-button-color branch from 4f156b3 to 68b1941 Compare February 17, 2023 10:12
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Feb 17, 2023

/werft run with-clean-slate-deployment=true with-preview=true recreate-vm=true

👍 started the job as gitpod-build-gt-update-primary-button-color.10
(with .werft/ from main)

@geropl
Copy link
Member

geropl commented Feb 21, 2023

@gtsiolis Although I saw the internal discussion, I'm not sure everybody is aligned yet. Also, I feel product should ultimately decide.
Would it make sense to hold this PR until then?

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Feb 21, 2023

DEAL—Let's hold this for now until consensus is reached. Thanks for the nudge, @geropl.

Cross-posting relevant discussion (internal) for visibility.

/hold

@gtsiolis gtsiolis force-pushed the gt/update-primary-button-color branch from 68b1941 to 2b01cdf Compare February 24, 2023 12:44
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Feb 24, 2023

/werft run with-clean-slate-deployment=true with-preview=true recreate-vm=true

👍 started the job as gitpod-build-gt-update-primary-button-color.12
(with .werft/ from main)

@gtsiolis gtsiolis mentioned this pull request Mar 2, 2023
15 tasks
@gtsiolis gtsiolis force-pushed the gt/update-primary-button-color branch from 2b01cdf to 2b7119c Compare March 10, 2023 17:38
@roboquat roboquat added size/XS and removed size/S labels Mar 10, 2023
@gtsiolis gtsiolis force-pushed the gt/update-primary-button-color branch from 2b7119c to 7f7df17 Compare March 20, 2023 20:03
@gtsiolis gtsiolis marked this pull request as draft March 23, 2023 09:40
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Mar 23, 2023

Marking this as draft to fine tune and remove it from the GH notifications in Slack.

@stale
Copy link

stale bot commented Apr 2, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Apr 2, 2023
@gtsiolis gtsiolis force-pushed the gt/update-primary-button-color branch from 7f7df17 to 047cb54 Compare April 26, 2023 20:30
@stale stale bot closed this May 2, 2023
This was referenced Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold do-not-merge/work-in-progress meta: stale This issue/PR is stale and will be closed soon release-note size/XS team: webapp Issue belongs to the WebApp team
Projects
Status: In Validation
Development

Successfully merging this pull request may close these issues.

3 participants