Skip to content

Update top navigation #18283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Update top navigation #18283

merged 1 commit into from
Jul 19, 2023

Conversation

gtsiolis
Copy link
Contributor

@gtsiolis gtsiolis commented Jul 14, 2023

Description

Reviving parts of #16433 to update the top navigation and tone down the active menu.

BEFORE AFTER
Frame 1712 Frame 1713
Frame 1714 Frame 1715
Frame 1716 Frame 1717

How to test

Log in and see how the top navigation no longer stands out much, overtaking the primary action of the page.

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

/hold

@gtsiolis gtsiolis requested a review from a team July 14, 2023 11:50
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Jul 14, 2023
@gtsiolis gtsiolis force-pushed the gt/update-top-navigation branch from b49b8ed to 8b5dbb7 Compare July 17, 2023 08:39
@gtsiolis
Copy link
Contributor Author

Build passed. 🏁

Ready-For-Review. 🏓

/unhold

@roboquat roboquat merged commit df2b16e into main Jul 19, 2023
@roboquat roboquat deleted the gt/update-top-navigation branch July 19, 2023 13:59
@gtsiolis
Copy link
Contributor Author

Thanks for taking a look, @svenefftinge. 🌮

@Sadeghi1017
Copy link

Very good

@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jul 19, 2023
@gtsiolis gtsiolis mentioned this pull request Jul 20, 2023
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production size/S team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants