Skip to content

New Settings option & New Workspace ... fix #16596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 3, 2023
Merged

New Settings option & New Workspace ... fix #16596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da1c422
New Settings option & `New Workspace ...` fix
Siddhant-K-code Feb 28, 2023
1c8f1de
Merge branch 'main' into feat/project-settings-from-list-item
Siddhant-K-code Mar 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/dashboard/src/projects/Project.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@ export default function ProjectsPage() {
? []
: [
{
title: "New Workspace ...",
title: "New Workspace with ...",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw I think this additional option will go away shortly and we'll be navigating to a new start workspace page where options are always available. I see we already approved merging this wording change a few times, so don't want to block it.

onClick: () =>
setStartWorkspaceModalProps({
contextUrl: branch.url,
Expand Down
7 changes: 6 additions & 1 deletion components/dashboard/src/projects/ProjectListItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export const ProjectListItem: FunctionComponent<ProjectListItemProps> = ({ proje
? []
: [
{
title: "New Workspace ...",
title: "New Workspace with ...",
onClick: () =>
setStartWorkspaceModalProps({
contextUrl: project.cloneUrl,
Expand All @@ -56,6 +56,11 @@ export const ProjectListItem: FunctionComponent<ProjectListItemProps> = ({ proje
separator: true,
},
]),
{
title: "Settings",
link: `/projects/${Project.slug(project)}/settings`,
separator: true,
},
{
title: "Remove Project",
customFontStyle:
Expand Down