[ws-manager-mk2] Refactor workspace status conditions #16896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Furisto
added
team: workspace
Furisto
force-pushed
the
fo/refactor-conditions
branch
from
54cd43f to
07ac6c5
Compare
Furisto
force-pushed
the
fo/refactor-conditions
branch
from
07ac6c5 to
6de449f
Compare
WVerlaek
approved these changes
Mar 17, 2023
| Type: string(WorkspaceConditionFirstUserActivity), | ||
| LastTransitionTime: metav1.Now(), | ||
| Status: metav1.ConditionTrue, | ||
| Reason: "MarkActiveRequest", |
There was a problem hiding this comment.
maybe we should change the Reason now, as it might be called from other places than the MarkActive request handler
14 tasks
Furisto
changed the title
roboquat
added
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor workspace status conditions to have less repetition.
Related Issue(s)
n.a.
Release Notes
Documentation
Build Options:
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish Options
Installer Options
Add desired feature flags to the end of the line above, space separated
Preview Environment Options:
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh