[ws-manager-mk2] Emit events for workspaces and snapshots #16907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Furisto
added
do-not-merge/hold
team: workspace
WVerlaek
approved these changes
Mar 20, 2023
| @@ -124,5 +128,20 @@ func (ssc *SnapshotReconciler) Reconcile(ctx context.Context, req ctrl.Request) | |||
| log.Error(err, "could not set completion status for snapshot", "workspace", snapshot.Spec.WorkspaceID) | |||
There was a problem hiding this comment.
unrelated to the PR, but would be nice to log the snapshotErr here if it fails to update the status
| @@ -114,12 +117,14 @@ func (r *WorkspaceReconciler) Reconcile(ctx context.Context, req ctrl.Request) ( | |||
| return ctrl.Result{}, err | |||
| } | |||
|
|
|||
| err = updateWorkspaceStatus(ctx, &workspace, workspacePods, r.Config) | |||
| oldStatus := workspace.Status | |||
There was a problem hiding this comment.
Suggested change
| oldStatus := workspace.Status | |
| oldStatus := workspace.Status.DeepCopy() |
to ensure e.g. pointers are also copied, don't think it makes any difference now but might in the future?
roboquat
added
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Emit events for workspaces and snapshots. Depends on #16896
`
Related Issue(s)
n.a.
How to test
Using https://g8a099d879e.workspace-preview.gitpod-io-dev.com/workspaces
kubectl get eventsRelease Notes
Build Options:
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish Options
Installer Options
Add desired feature flags to the end of the line above, space separated
Preview Environment Options:
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh