Skip to content

[public-api] Add BlockUser rpc #17000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Mar 23, 2023

Description

Related Issue(s)

Fixes #

How to test

Release Notes

NONE

Documentation

Build Options:

  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-ee-license
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@easyCZ easyCZ requested a review from a team March 23, 2023 14:54
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Mar 23, 2023
string user_id = 1;

// reason is the reason for blocking the user
string reason = 2;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not storing this today, but we can at least log it in our handler for now, until we start storing it.

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

11 lines vs 408 lines 🙈

Gotta love those generators! (incl. our rule to check-in their outpur 🙃 )

@easyCZ
Copy link
Member Author

easyCZ commented Mar 23, 2023

Just trust the codegen, the rest of the files "should" be folded and safe to ignore

@roboquat roboquat merged commit 6fcfe25 into main Mar 23, 2023
@roboquat roboquat deleted the mp/public-api-add-block-user-rpc branch March 23, 2023 15:35
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/M team: webapp Issue belongs to the WebApp team
Projects
Status: In Validation
Development

Successfully merging this pull request may close these issues.

3 participants