Skip to content

[server] gRPC/Connect Unimplemented User Service #16999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2023
Merged

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Mar 23, 2023

Description

Adds an un-implemented UserService onto server. This service is a gRPC/connect service, which conforms to the same interface as the public-api as per WebApp architectural direction.

Currently unused, but will be used by as part of https://github.com/gitpod-io/ops/issues/8192 to issue a BlockUser call

Related Issue(s)

How to test

  1. Preview
  2. Port forward k port-forward deployment/server 9877:9877
  3. curl \
        --header "Content-Type: application/json" \
        --data '{}' \                           
        http://localhost:9877/gitpod.experimental.v1.UserService/BlockUser
    
    {"code":"unimplemented","message":"unimplemented"}
    

Release Notes

NONE

Documentation

Build Options:

  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-ee-license
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@easyCZ easyCZ requested a review from a team March 23, 2023 14:52
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-mp-server-user-service.1 because the annotations in the pull request description changed
(with .werft/ from main)

@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Mar 23, 2023
@easyCZ easyCZ marked this pull request as draft March 23, 2023 14:55
@easyCZ easyCZ force-pushed the mp/server-user-service branch 2 times, most recently from e76528d to 6beb9df Compare March 25, 2023 19:47
@socket-security
Copy link

socket-security bot commented Mar 25, 2023

New dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package Capability Access +/- Transitive Count Publisher
@bufbuild/[email protected] None +12 tstamm-buf
@types/[email protected] None +4 types
@bufbuild/[email protected] None +2 tstamm-buf

@easyCZ easyCZ force-pushed the mp/server-user-service branch from 6beb9df to b24ce96 Compare March 25, 2023 19:47
@easyCZ easyCZ marked this pull request as ready for review March 25, 2023 19:56
@easyCZ easyCZ mentioned this pull request Mar 25, 2023
14 tasks
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested and works! 🚀

@roboquat roboquat merged commit d6629f3 into main Mar 27, 2023
@roboquat roboquat deleted the mp/server-user-service branch March 27, 2023 07:26
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/L team: webapp Issue belongs to the WebApp team
Projects
Status: In Validation
Development

Successfully merging this pull request may close these issues.

3 participants