Skip to content

[server] Expose gRPC API port to public-api & usage #17032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Mar 25, 2023

Description

Related Issue(s)

How to test

  1. kubectl port-forward service/server 9877:9877
  2. curl \
    --header "Content-Type: application/json" \
    --data '{}' \                           
    http://localhost:9877/gitpod.experimental.v1.UserService/BlockUser
    
    {"code":"unimplemented","message":"unimplemented"}
    

Release Notes

NONE

Documentation

Build Options:

  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-ee-license
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

/hold for dependency

@socket-security
Copy link

socket-security bot commented Mar 25, 2023

New dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

@easyCZ easyCZ changed the base branch from main to mp/server-user-service March 25, 2023 19:55
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Mar 25, 2023
@roboquat roboquat added size/M and removed size/L labels Mar 25, 2023
@easyCZ easyCZ changed the title [server] Unimplemented user service on internal port [server] Expose gRPC API port to public-api & usage Mar 25, 2023
Base automatically changed from mp/server-user-service to main March 27, 2023 07:26
@roboquat roboquat added size/L and removed size/M labels Mar 27, 2023
@easyCZ easyCZ force-pushed the mp/server-expose-9877 branch from 63bcb98 to e2c0cf5 Compare March 27, 2023 07:42
@roboquat roboquat added size/M and removed size/L labels Mar 27, 2023
@easyCZ
Copy link
Member Author

easyCZ commented Mar 27, 2023

/unhold dependency satisfied

@easyCZ
Copy link
Member Author

easyCZ commented Mar 27, 2023

/unhold

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roboquat roboquat merged commit 2c1ff94 into main Mar 27, 2023
@roboquat roboquat deleted the mp/server-expose-9877 branch March 27, 2023 08:55
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/M team: webapp Issue belongs to the WebApp team
Projects
Status: In Validation
Development

Successfully merging this pull request may close these issues.

3 participants