Implement user account verification with LinkedIn during onboarding #17074

jankeromnes · 2023-03-29T09:44:20Z

Description

Implement user account verification with LinkedIn during onboarding.

Related Issue(s)

Fixes #

How to test

Try onboading flow
Verify your account by connecting to LinkedIn

Release Notes

Implement user account verification with LinkedIn during onboarding

Documentation

Build Options:

/werft with-werft
Run the build with werft instead of GHA
leeway-no-cache
/werft no-test
Run Leeway with --dont-test

Publish Options

/werft publish-to-npm
/werft publish-to-jb-marketplace

Installer Options

with-dedicated-emulation
with-ws-manager-mk2
workspace-feature-flags
Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

/werft with-local-preview
If enabled this will build install/preview
/werft with-preview
/werft with-large-vm
/werft with-gce-vm
If enabled this will create the environment on GCE infra
with-integration-tests=all
Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh
/werft analytics=segment

werft-gitpod-dev-com · 2023-03-29T09:44:28Z

started the job as gitpod-build-jx-connect-linkedin.1 because the annotations in the pull request description changed
(with .werft/ from main)

socket-security · 2023-03-29T09:46:40Z

New dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary

Issue	Status
Install scripts	✅ 0 issues
Native code	✅ 0 issues
Bin script shell injection	✅ 0 issues
Unresolved require	✅ 0 issues
Invalid package.json	✅ 0 issues
HTTP dependency	✅ 0 issues
Git dependency	✅ 0 issues
Potential typo squat	✅ 0 issues
Known Malware	✅ 0 issues
Telemetry	✅ 0 issues
Protestware/Troll package	✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package	Capability Access	`+/-` Transitive Count	Publisher
[email protected]	None	`+0`	nvh95

gitguardian · 2023-03-30T10:38:23Z

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.

^{_{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}}

components/server/ee/src/user/linkedin-service.ts

components/dashboard/src/onboarding/UserOnboarding.tsx

components/gitpod-db/src/typeorm/entity/db-linked-in-token.ts

werft-gitpod-dev-com · 2023-04-11T12:16:05Z

started the job as gitpod-build-jx-connect-linkedin.17 because the annotations in the pull request description changed
(with .werft/ from main)

gtsiolis · 2023-04-12T11:45:15Z

Looking at this now! 👀

svenefftinge · 2023-04-12T11:49:26Z

I'm not sure this works:
I clicked the "Connect with LinkedIn" button and giot immediately forward to the next page where I pick editor.
I would have expected some sort of pop-up from LinkedIn or so.

components/server/ee/src/workspace/gitpod-server-impl.ts

components/server/ee/src/user/linkedin-service.ts

components/server/ee/src/container-module.ts

svenefftinge · 2023-04-12T11:59:14Z

components/gitpod-db/src/typeorm/migration/1680096507296-LinkedInProfile.ts

+export class LinkedInProfile1680096507296 implements MigrationInterface {
+    public async up(queryRunner: QueryRunner): Promise<void> {
+        await queryRunner.query(
+            `CREATE TABLE IF NOT EXISTS ${TABLE_NAME} (id char(36) NOT NULL, userId char(36) NOT NULL, profile text NOT NULL, creationTime varchar(255) NOT NULL, _lastModified timestamp(6) NOT NULL DEFAULT CURRENT_TIMESTAMP(6) ON UPDATE CURRENT_TIMESTAMP(6), PRIMARY KEY (id)) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4;`,


should this not be unique per user?

@svenefftinge it could be. Please explicitly mention what you're expecting to see different in this CREATE statement. 🙂

no id but making the userid the PK

Great idea, thanks!

components/dashboard/src/app/AppRoutes.tsx

gtsiolis

Took a closer look at the UX.

Thanks for your patience while adding 500 lines for one button, @jankeromnes. 🙇

components/dashboard/src/onboarding/OnboardingStep.tsx

gtsiolis · 2023-04-12T12:00:55Z

components/dashboard/src/onboarding/LinkedInBanner.tsx

+                <Button
+                    className="w-full flex items-center justify-center space-x-2"
+                    onClick={linkedInLogin}
+                    disabled={isLoading || !clientID}
+                >
+                    <img src={SignInWithLinkedIn} width={20} height={20} alt="Sign in with Linked In" />
+                    <span>Connect with LinkedIn</span>
+                </Button>


question: Clicking this just redirected me to the next step as @svenefftinge mentioned in #17074 (comment). Is this expected?

Re-posting here an export from the design specs.

Thanks for noticing @gtsiolis!

The auto-forward without LinkedIn pop-up should now be fixed.

Also,

only the Default spec is implemented right now

the Success spec is not necessary given that success auto-forwards to the next page

the Error spec is not implemented yet (errors are logged into the console instead)

I'm not sure when the Skip spec should be used if at all

Please let me know what exactly is blocking this PR from being merged, or please resolve if nothing is blocking 😁

jankeromnes · 2023-04-12T12:05:43Z

Many thanks for the early review comments! 🙌

I'm not sure this works:
I clicked the "Connect with LinkedIn" button and giot immediately forward to the next page where I pick editor.
I would have expected some sort of pop-up from LinkedIn or so.

Huh, you're right. It used to work, but in the latest state it just auto-forwards 🤨 taking a look to find what broke.

EDIT: Fixed. ✅

svenefftinge · 2023-04-12T12:07:01Z

The design is assuming that we give credits to individuals, which is not the case. We give credits to organizations. A new user might not create an organization so there is no way they can benefit from the promised credits cc @phimae

jankeromnes · 2023-04-12T12:10:10Z

Taking this back to draft while I investigate why the LinkedIn pop-up no longer shows up.

phimae · 2023-04-12T12:14:40Z

The design is assuming that we give credits to individuals, which is not the case. We give credits to organizations. A new user might not create an organization so there is no way they can benefit from the promised credits cc @phimae

What happens if the user does not create their own org? Do they get zero credits until they do so? Are there any nudges in the product for that?

Does the above change based on the LinkedIn connector? If I understand correctly then even today a user would not benefit from the 500 credits if they don't create an org? The change we make is just making the 500 everyone gets today contingent of the Linkedin connection

jankeromnes · 2023-04-12T12:14:54Z

Looks like the LinkedIn button click auto-submits the form, without giving a chance for the LinkedIn pop-up to show up.

You can make it work by emptying one of the required fields (first name or last name) before clicking on the LinkedIn button. Working on a fix.

EDIT: Fixed in telepresence and pushing the fix now. ✅

easyCZ · 2023-04-12T12:15:46Z

We'll also need a follow-up which deletes the LinkedIN data whenever the user chooses to delete their account to conform to GDPR.

jankeromnes · 2023-04-12T13:47:40Z

Ready for another round of reviews! 🏓

svenefftinge · 2023-04-12T13:57:05Z

What happens if the user does not create their own org? Do they get zero credits until they do so? Are there any nudges in the product for that?

Users will not get credits t all. The only possible cost center is an org. We are making it so that the first org a user creates gets the free credits. So this is not part of the user account creation but the following creation of an org, which only happens if the user is not automatically added to an existing org.

svenefftinge

Works now and the code looks good as well!
I'm ok with just ignoring my comment around credits as we are currently giving every user 500 credits no matter they have opted-in or not. So it doesn't really change anything.

ozeliger · 2023-04-18T15:28:50Z

What was the reasoning behind adding a Linkedin verification? Imo seems a little non-relevant, no? You're already connecting your Github account -- why connect a Linkedin account. Further, folks that don't link their Linkedin acc get only 100 credits as opposed to 500 if they do link. Why? Seems a little odd
@jankeromnes

roboquat added do-not-merge/work-in-progress release-note labels Mar 29, 2023

roboquat added the size/L label Mar 29, 2023

jankeromnes force-pushed the jx/connect-linkedin branch 5 times, most recently from 175d079 to f1feecf Compare March 30, 2023 10:38

jankeromnes force-pushed the jx/connect-linkedin branch from f1feecf to aa48b54 Compare March 30, 2023 10:43

selfcontained reviewed Mar 30, 2023

View reviewed changes

components/server/ee/src/user/linkedin-service.ts Outdated Show resolved Hide resolved

selfcontained reviewed Mar 30, 2023

View reviewed changes

components/dashboard/src/onboarding/UserOnboarding.tsx Outdated Show resolved Hide resolved

roboquat added size/XL and removed size/L labels Mar 30, 2023

jankeromnes mentioned this pull request Mar 31, 2023

Configure LinkedIn in preview environments #17110

Merged

13 tasks

jankeromnes force-pushed the jx/connect-linkedin branch 3 times, most recently from 4a3e9bb to 0ae2c61 Compare April 4, 2023 16:52

jankeromnes commented Apr 4, 2023

View reviewed changes

components/gitpod-db/src/typeorm/entity/db-linked-in-token.ts Outdated Show resolved Hide resolved

jankeromnes and others added 5 commits April 11, 2023 07:59

Implement user account verification with LinkedIn during onboarding

26131d2

updating connect with linked-in banner

9e283ec

removing unused imports

bec4742

Store token, fix binding

8d5caee

Refactor LinkedInToken to LinkedInProfile

5e00849

jankeromnes force-pushed the jx/connect-linkedin branch from 206e46f to 5e00849 Compare April 11, 2023 07:59

Actually write the LinkedIn secret to the server config

8404d01

Fetch LinkedIn user profile and email address

605326b

github-actions bot added the team: webapp Issue belongs to the WebApp team label Apr 12, 2023

jankeromnes requested review from selfcontained, geropl and phimae April 12, 2023 10:21

svenefftinge reviewed Apr 12, 2023

View reviewed changes

gtsiolis reviewed Apr 12, 2023

View reviewed changes

jankeromnes marked this pull request as draft April 12, 2023 12:10

roboquat added the do-not-merge/work-in-progress label Apr 12, 2023

jankeromnes added 2 commits April 12, 2023 12:18

Prevent the LinkedIn button from auto-submitting the onboarding form

988c68a

Address nits (LinkedInService to /src and minor spacing)

4619e28

jankeromnes marked this pull request as ready for review April 12, 2023 13:47

roboquat removed the do-not-merge/work-in-progress label Apr 12, 2023

jankeromnes requested a review from svenefftinge April 12, 2023 13:47

svenefftinge approved these changes Apr 12, 2023

View reviewed changes

roboquat merged commit f7101c5 into main Apr 12, 2023

roboquat deleted the jx/connect-linkedin branch April 12, 2023 14:39

roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Apr 17, 2023

jankeromnes mentioned this pull request Apr 26, 2023

Also delete any LinkedIn profile when deleting a user account #17388

Closed

14 tasks

Implement user account verification with LinkedIn during onboarding #17074

Implement user account verification with LinkedIn during onboarding #17074

Uh oh!

Conversation

jankeromnes commented Mar 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue(s)

How to test

Release Notes

Documentation

Build Options:

Preview Environment Options:

Uh oh!

werft-gitpod-dev-com bot commented Mar 29, 2023

Uh oh!

socket-security bot commented Mar 29, 2023 • edited by werft-gitpod-dev-com bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gitguardian bot commented Mar 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

️✅ There are no secrets present in this pull request anymore.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

werft-gitpod-dev-com bot commented Apr 11, 2023

Uh oh!

gtsiolis commented Apr 12, 2023 • edited by werft-gitpod-dev-com bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

svenefftinge commented Apr 12, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

svenefftinge Apr 12, 2023

Choose a reason for hiding this comment

Uh oh!

jankeromnes Apr 12, 2023

Choose a reason for hiding this comment

Uh oh!

svenefftinge Apr 12, 2023

Choose a reason for hiding this comment

Uh oh!

jankeromnes Apr 12, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gtsiolis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gtsiolis Apr 12, 2023

Choose a reason for hiding this comment

Uh oh!

jankeromnes Apr 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jankeromnes commented Apr 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

svenefftinge commented Apr 12, 2023

Uh oh!

jankeromnes commented Apr 12, 2023

Uh oh!

phimae commented Apr 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jankeromnes commented Apr 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

easyCZ commented Apr 12, 2023

Uh oh!

jankeromnes commented Apr 12, 2023 • edited by werft-gitpod-dev-com bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

svenefftinge commented Apr 12, 2023

Uh oh!

jankeromnes commented Mar 29, 2023 •

edited

Loading

socket-security bot commented Mar 29, 2023 •

edited by werft-gitpod-dev-com bot

Loading

gitguardian bot commented Mar 30, 2023 •

edited

Loading

gtsiolis commented Apr 12, 2023 •

edited by werft-gitpod-dev-com bot

Loading

jankeromnes Apr 12, 2023 •

edited

Loading

jankeromnes commented Apr 12, 2023 •

edited

Loading

phimae commented Apr 12, 2023 •

edited

Loading

jankeromnes commented Apr 12, 2023 •

edited

Loading

jankeromnes commented Apr 12, 2023 •

edited by werft-gitpod-dev-com bot

Loading

ozeliger commented Apr 18, 2023 •

edited

Loading