Also delete any LinkedIn profile when deleting a user account #17388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easyCZ
reviewed
Apr 26, 2023
|
|
||
| public async deleteProfile(userId: string): Promise<void> { | ||
| const repo = await this.getRepo(); | ||
| await repo.delete({ userId }); |
There was a problem hiding this comment.
Will this throw if the userId does not exist?
There was a problem hiding this comment.
The documentation says:
Deletes entities by a given criteria. Unlike save method executes a primitive operation without cascades, relations and other operations included. Executes fast and efficient DELETE query. Does not check if entity exist in the database.
easyCZ
reviewed
Apr 26, 2023
jankeromnes
force-pushed
the
jx/delete-linked-in
branch
from
c5054d0 to
1c2515b
Compare
|
As per https://linear.app/gitpod/issue/WEB-134#comment-1e3e0fde, we should close this PR and leave it without the delete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Also delete any LinkedIn profile when deleting a user account
Related Issue(s)
Fixes #17074 (comment)
Fixes item 4. in Slack message (internal)
Fixes Linear issue (internal)
How to test
Documentation
Preview status
gitpod:summary
Build Options:
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish Options
Installer Options
Add desired feature flags to the end of the line above, space separated
Preview Environment Options:
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh/hold