[installer] Remove messagebus WEB-618 #18216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easyCZ
force-pushed
the
mp/installer-remove-messagebus
branch
from
243eaeb to
dba4cd1
Compare
github-actions
bot
added
team: webapp
13 tasks
svenefftinge
approved these changes
Jul 13, 2023
easyCZ
force-pushed
the
mp/server-remove-messagebus
branch
from
84b9e7c to
83e86a4
Compare
aledbf
approved these changes
Jul 24, 2023
easyCZ
force-pushed
the
mp/installer-remove-messagebus
branch
from
dba4cd1 to
0b8745b
Compare
easyCZ
commented
Jul 24, 2023
| @@ -121,6 +121,7 @@ type Config struct { | |||
|
|
|||
| Database Database `json:"database" validate:"required"` | |||
|
|
|||
| // Deprecated. | |||
| MessageBus *MessageBus `json:"messageBus,omitempty"` | |||
There was a problem hiding this comment.
This ensures that existing configs which do mention the messagebus do continue to work. This allows us to remove it from other places (dedicated) before removing it from code.
vulkoingim
approved these changes
Jul 24, 2023
geropl
approved these changes
Jul 24, 2023
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
How to test
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh/hold