Skip to content

[server, ws-man-bridge] Remove messagebus WEB-618 #18238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 31 commits into from
Jul 24, 2023
Merged

[server, ws-man-bridge] Remove messagebus WEB-618 #18238

merged 31 commits into from
Jul 24, 2023

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Jul 11, 2023 •
edited
Loading

Description

Removes:

  • Messagebus interaction from server and ws-man-bridge
  • Feature flag for controlling whether redis or rabbitmq are used

Related Issue(s)

How to test

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

/hold

@easyCZ easyCZ changed the base branch from main to mp/server-headless-updates July 11, 2023 14:32
@easyCZ easyCZ force-pushed the mp/server-remove-messagebus branch from cbbe010 to a22f240 Compare July 11, 2023 14:33
@easyCZ easyCZ changed the title [server] Remove messagebus [server, ws-man-bridge] Remove messagebus Jul 11, 2023
@easyCZ easyCZ force-pushed the mp/server-headless-updates branch 2 times, most recently from a5f0f9b to 4910931 Compare July 12, 2023 12:28
@easyCZ easyCZ force-pushed the mp/server-remove-messagebus branch from 779dfd5 to bb3e182 Compare July 12, 2023 12:31
@easyCZ easyCZ changed the title [server, ws-man-bridge] Remove messagebus [server, ws-man-bridge] Remove messagebus WEB-618 Jul 12, 2023
@easyCZ easyCZ force-pushed the mp/server-headless-updates branch from 4910931 to 43ee367 Compare July 12, 2023 14:40
Base automatically changed from mp/server-headless-updates to main July 12, 2023 14:59
@easyCZ easyCZ force-pushed the mp/server-remove-messagebus branch from 01d4c62 to 132753a Compare July 12, 2023 15:05
@easyCZ easyCZ mentioned this pull request Jul 13, 2023
Merged
13 tasks
@easyCZ easyCZ marked this pull request as ready for review July 13, 2023 05:33
@easyCZ easyCZ requested a review from a team July 13, 2023 05:33
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Jul 13, 2023
@easyCZ easyCZ force-pushed the mp/server-remove-messagebus branch from 84b9e7c to 83e86a4 Compare July 24, 2023 08:32
@easyCZ easyCZ requested a review from a team as a code owner July 24, 2023 08:32
@geropl
Copy link
Member

geropl commented Jul 24, 2023

Re-reviewing now... 👀

geropl
geropl approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, tested and works. ✔️

@easyCZ
Copy link
Member Author

easyCZ commented Jul 24, 2023

/unhold

Bye, and thanks for all the fish.

@roboquat roboquat merged commit a5b4a66 into main Jul 24, 2023
@roboquat roboquat deleted the mp/server-remove-messagebus branch July 24, 2023 10:04
@roboquat roboquat added the deployed: webapp Meta team change is running in production label Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svenefftinge svenefftinge svenefftinge approved these changes

@geropl geropl geropl approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production size/XXL team: team-experience team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@easyCZ @geropl @svenefftinge @roboquat