-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[proxy] Add services.DOMAIN handlers for IDP and Apps ENG-524 #18357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
reverse_proxy public-api-server.{$KUBE_NAMESPACE}.{$KUBE_DOMAIN}:9002 | ||
} | ||
|
||
handle /apps/* { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to make this webhooks/apps/*
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we need to stay compatible with the current pathes (there are many configured webhooks) I believe it is not worth changing
Are you going to make the relevant changes to gitpod/components/server/src/prebuilds/github-service.ts Lines 102 to 109 in dd331db
|
Yes, will follow-up with it after. Initially looking to unblock the Networking changes with this PR. |
Can confirm that
both work with this config |
/unhold |
Description
Summary generated by Copilot
🤖 Generated by Copilot at 9aea4b2
Add proxy configuration for services subdomain in
Caddyfile
. This enables the identity provider and app store features of Gitpod.Related Issue(s)
Fixes #
How to test
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-test
Publish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment
If enabled this will build
install/preview
If enabled this will create the environment on GCE infra
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh
/hold