Skip to content

[proxy] Add services.DOMAIN handlers for IDP and Apps ENG-524 #18357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 26, 2023
Merged

[proxy] Add services.DOMAIN handlers for IDP and Apps ENG-524 #18357

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9aea4b2
[proxy] Add services.DOMAIN handlers for IDP and Apps
easyCZ Jul 26, 2023
dd331db
retest
easyCZ Jul 26, 2023
f9b812a
fix
easyCZ Jul 26, 2023
87fdf01
fix
easyCZ Jul 26, 2023
ffc3364
fix
easyCZ Jul 26, 2023
d0279f5
fix
easyCZ Jul 26, 2023
51eb62a
fix
easyCZ Jul 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions components/proxy/conf/Caddyfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,23 @@ http:// {
redir https://{host}{uri} permanent
}

# The services directly correlate to Public Services exposed by Dedicated
# When adding new endpoints, please notify Team Engine
https://services.{$GITPOD_DOMAIN} {
import enable_log
import remove_server_header
import ssl_configuration
import security_headers

handle /idp/* {
reverse_proxy public-api-server.{$KUBE_NAMESPACE}.{$KUBE_DOMAIN}:9002
}

handle /apps/* {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to make this webhooks/apps/*?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we need to stay compatible with the current pathes (there are many configured webhooks) I believe it is not worth changing

reverse_proxy server.{$KUBE_NAMESPACE}.{$KUBE_DOMAIN}:3000
}
}

https://{$GITPOD_DOMAIN} {
import enable_log
import remove_server_header
Expand Down