-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[server/FGA] relationship updates/migration setup #18369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenefftinge
commented
Jul 27, 2023
a744dbd
to
daa7359
Compare
This was referenced Jul 28, 2023
akosyakov
approved these changes
Jul 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we reviewed it together
geropl
reviewed
Jul 28, 2023
geropl
reviewed
Jul 28, 2023
geropl
reviewed
Jul 28, 2023
geropl
reviewed
Jul 28, 2023
geropl
reviewed
Jul 28, 2023
geropl
reviewed
Jul 28, 2023
geropl
reviewed
Jul 28, 2023
geropl
reviewed
Jul 28, 2023
geropl
reviewed
Jul 28, 2023
geropl
reviewed
Jul 28, 2023
geropl
reviewed
Jul 28, 2023
@svenefftinge Done with a first pass, and basically have two questions (the rest are questions/nits): |
324832a
to
c265c07
Compare
14 tasks
c265c07
to
25bfd86
Compare
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces an idempotent
relationship-updater
that can be called for a given user and will establish all relationships in spicedb according to the current DB state.The idea is that we keep this updater around and use that as a migrator whenever we change something in our spicedb schema or logic. We would run this on every DB read (I would like to put it into findById) so that whenever a new version is deployed we will run this on any users that have bnot seen the update.
Summary generated by Copilot
🤖 Generated by Copilot at 7d423e3
No summary available (Limit exceeded: required to process 85889 tokens, but only 50000 are allowed per call)
Related Issue(s)
Fixes EXP-276
Fixes EXP-280
How to test
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-test
Publish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment
If enabled this will build
install/preview
If enabled this will create the environment on GCE infra
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh
/hold