Skip to content

[server/FGA] relationship updates/migration setup #18369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Conversation

svenefftinge
Copy link
Member

@svenefftinge svenefftinge commented Jul 27, 2023

Description

Introduces an idempotent relationship-updater that can be called for a given user and will establish all relationships in spicedb according to the current DB state.

The idea is that we keep this updater around and use that as a migrator whenever we change something in our spicedb schema or logic. We would run this on every DB read (I would like to put it into findById) so that whenever a new version is deployed we will run this on any users that have bnot seen the update.

Summary generated by Copilot

🤖 Generated by Copilot at 7d423e3

No summary available (Limit exceeded: required to process 85889 tokens, but only 50000 are allowed per call)

Related Issue(s)

Fixes EXP-276
Fixes EXP-280

How to test

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh
  • with-monitoring

/hold

Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we reviewed it together

@geropl
Copy link
Member

geropl commented Jul 28, 2023

@svenefftinge Done with a first pass, and basically have two questions (the rest are questions/nits):

@svenefftinge svenefftinge force-pushed the se/migration branch 3 times, most recently from 324832a to c265c07 Compare July 28, 2023 10:20
@geropl geropl mentioned this pull request Jul 28, 2023
14 tasks
@svenefftinge
Copy link
Member Author

/unhold

@roboquat roboquat merged commit 8b4fbb4 into main Jul 28, 2023
@roboquat roboquat deleted the se/migration branch July 28, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants