Skip to content

[spicedb] Small schema adjustments #18380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 28, 2023
Merged

[spicedb] Small schema adjustments #18380

merged 2 commits into from
Jul 28, 2023

Conversation

geropl
Copy link
Member

@geropl geropl commented Jul 28, 2023

Description

Small changes based on this discussion: https://gitpod.slack.com/archives/C05JERNDYLE/p1690532118878689

Let's wait with this until #18369 got merged. ✔️

Summary generated by Copilot

🤖 Generated by Copilot at 8cb2f65

Updated the user model and permissions in the SpiceDB schema and added a validation step for the schema file.

Related Issue(s)

Fixes #

How to test

Documentation

Preview status

gitpod:summary

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@geropl geropl force-pushed the gpl/fga-user-comments branch from 8cb2f65 to 561fe45 Compare July 28, 2023 13:10
@roboquat roboquat added size/M and removed size/S labels Jul 28, 2023
@geropl geropl force-pushed the gpl/fga-user-comments branch 2 times, most recently from 15a253f to f882094 Compare July 28, 2023 13:27
@geropl geropl force-pushed the gpl/fga-user-comments branch from f882094 to 10bc9c2 Compare July 28, 2023 13:57
@geropl geropl marked this pull request as ready for review July 28, 2023 14:04
@geropl geropl requested a review from a team as a code owner July 28, 2023 14:04
@geropl
Copy link
Member Author

geropl commented Jul 28, 2023

/unhold

Copy link
Member

@svenefftinge svenefftinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roboquat roboquat merged commit 850cc04 into main Jul 28, 2023
@roboquat roboquat deleted the gpl/fga-user-comments branch July 28, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants