Skip to content

unblock EXP-96 #18387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2023
Merged

unblock EXP-96 #18387

merged 1 commit into from
Jul 31, 2023

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Jul 31, 2023

Description

Temporary disable auto-attach of the async-profiler to prevent JVM crash. See internal Slack thread

Summary generated by Copilot

🤖 Generated by Copilot at 85573e4

Disable async-profiler attachment in JetBrains IDEs to avoid JVM crashes. Modify updateVMOptions in components/ide/jetbrains/launcher/main.go to add a new VM option based on an environment variable.

Related Issue(s)

Related to EXP-96

How to test

Smoke a workspace startup with IntelliJ (stable and latest).

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know how to test, approving to unblock. ✅

/hold

temporary disable auto-attach of the async-profiler to prevent JVM crash
@akosyakov akosyakov force-pushed the ak/jb_disable_freeze_profiling branch from 85573e4 to aadd65b Compare July 31, 2023 11:35
@roboquat roboquat added size/S and removed size/XS labels Jul 31, 2023
Copy link
Member

@filiptronicek filiptronicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Connecting works on both stable and latest.

image

Wow, the new UI JB has is really nice.

@akosyakov
Copy link
Member Author

@filiptronicek thanks for testing, was about doing it 😄

/unhold

@roboquat roboquat merged commit 0b5a71a into main Jul 31, 2023
@roboquat roboquat deleted the ak/jb_disable_freeze_profiling branch July 31, 2023 13:59
jeanp413 added a commit that referenced this pull request Oct 18, 2023
This reverts commit 0b5a71a.
roboquat pushed a commit that referenced this pull request Oct 18, 2023
akosyakov added a commit that referenced this pull request Oct 25, 2023
roboquat pushed a commit that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants