Skip to content

Revert "unblock EXP-96 (#18387)" #18944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2023
Merged

Revert "unblock EXP-96 (#18387)" #18944

merged 1 commit into from
Oct 18, 2023

Conversation

jeanp413
Copy link
Member

@jeanp413 jeanp413 commented Oct 18, 2023 •
edited by github-actions bot
Loading

Description

This reverts commit 0b5a71a.

Summary generated by Copilot

🤖 Generated by Copilot at b6727fb

Remove async-profiler workaround for JetBrains IDEs. Update tests for updateVMOptions function in main_test.go.

Related Issue(s)

Fixes #

How to test

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@jeanp413
Revert "unblock EXP-96 (#18387)"
b6727fb 
This reverts commit 0b5a71a.
@gitpod-io gitpod-io deleted a comment from linear bot Oct 18, 2023
@jeanp413
Copy link
Member Author

jeanp413 commented Oct 18, 2023 •
edited by github-actions bot
Loading

/gh run recreate-vm

Comment triggered a workflow run

Started workflow run: 6556352232

  • recreate_vm: true

@jeanp413 jeanp413 marked this pull request as ready for review October 18, 2023 06:01
@jeanp413 jeanp413 requested a review from a team as a code owner October 18, 2023 06:01
filiptronicek
filiptronicek approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@filiptronicek filiptronicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock

@roboquat roboquat merged commit 0fd84a5 into main Oct 18, 2023
@roboquat roboquat deleted the revert-18387-ak/jb_disable_freeze_profiling branch October 18, 2023 19:50
akosyakov added a commit that referenced this pull request Oct 25, 2023
@akosyakov
Revert "Revert "unblock EXP-96 (#18387)" (#18944)"
2b8e44b 
This reverts commit 0fd84a5.
@akosyakov akosyakov mentioned this pull request Oct 25, 2023
Merged
roboquat pushed a commit that referenced this pull request Oct 25, 2023
@akosyakov
Revert "Revert "unblock EXP-96 (#18387)" (#18944)" (#18973)
4bc3a76 
This reverts commit 0fd84a5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filiptronicek filiptronicek filiptronicek approved these changes

Assignees
No one assigned
Labels
size/S team: team-experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeanp413 @filiptronicek @roboquat