[server] Merge WorkspaceDeletionService into WorkspaceGC #18410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geropl
force-pushed
the
gpl/fga-workspace-1
branch
2 times, most recently
from
72ab824 to
a1e5387
Compare
svenefftinge
approved these changes
Aug 3, 2023
geropl
force-pushed
the
gpl/fga-workspace-1b
branch
from
3755662 to
08a9dc2
Compare
geropl
force-pushed
the
gpl/fga-workspace-1b
branch
from
08a9dc2 to
30a9453
Compare
14 tasks
|
/unhold |
AlexTugarev
added a commit
that referenced
this pull request
Aug 8, 2023
)" This reverts commit 9acc185.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merge WorkspaceDeletionService into WorkspaceGC
Summary generated by Copilot
🤖 Generated by Copilot at 3755662
This pull request improves the performance and maintainability of the workspace garbage collection feature by replacing the
ContentServicewith theStorageClientfor deleting workspace data, and by removing the unusedWorkspaceDeletionServiceand its related code.Related Issue(s)
Blocked by, and follow-up for, #18403
How to test
Documentation
Preview status
gitpod:summary
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold