[fga] WorkspaceService.getOwnerToken + getIDECredentials #18412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geropl
force-pushed
the
gpl/fga-workspace-3
branch
from
34b9acc to
2be105e
Compare
svenefftinge
approved these changes
Aug 3, 2023
geropl
force-pushed
the
gpl/fga-workspace-1b
branch
2 times, most recently
from
08a9dc2 to
30a9453
Compare
geropl
force-pushed
the
gpl/fga-workspace-3
branch
from
2be105e to
5777c75
Compare
14 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Blocked by: #18410
Adds WorkspaceService.getOwnerToken + getIDECredentials, incl. basic tests
Summary generated by Copilot
🤖 Generated by Copilot at 34b9acc
This pull request enhances the
WorkspaceServiceclass with new methods for owner token and IDE credentials logic, and refactors theGitpodServerImplclass and theworkspace-service.spec.db.tsfile to use the improved service layer. These changes aim to reduce code duplication, improve modularity, and increase test coverage and quality for the workspace component.Related Issue(s)
Fixes EXP-318, EXP-319
How to test
Documentation
Preview status
gitpod:summary
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold