[fga] extract WorkspaceService.start #18467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
akosyakov
commented
Aug 10, 2023
akosyakov
force-pushed
the
ak/fga_workspace_start
branch
from
bf39da2 to
7a1394b
Compare
akosyakov
changed the title
akosyakov
force-pushed
the
ak/fga_workspace_start
branch
3 times, most recently
from
b767d6f to
3cac29d
Compare
geropl
force-pushed
the
ak/fga_workspace_start
branch
2 times, most recently
from
6e2afa6 to
d3739c2
Compare
geropl
force-pushed
the
ak/fga_workspace_start
branch
from
8ffcb7a to
76566dd
Compare
|
@akosyakov I rebased, changed 2 minor things and tested in the preview env. Is there anything specific you wanted to test? |
|
@geropl not really, mostly workspace create/start and admin operations which we changed for blocking |
|
Will test the blocking, one sec... |
|
Works. ✔️ |
|
landing? |
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extracts api.startWorkspace into WorkspaceService.startWorkspace, and adds some basic tests.
🤖 Generated by Copilot at 7a1394b
This pull request refactors the server-side code for starting and stopping workspaces, by using a new
WorkspaceServiceinterface that consolidates the logic and checks the permissions, entitlements, limits, and other parameters. It also updates the tests and other components that depend on the oldWorkspaceStarterinterface, and improves the region guessing logic.Related Issue(s)
Fixes EXP-321
How to test
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold