Skip to content

Improve organization members filter #18480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Conversation

gtsiolis
Copy link
Contributor

@gtsiolis gtsiolis commented Aug 10, 2023

Description

UX updates for the organization members page, improving the role filter.

Extracting some first ideas from the relevant frame (internal). Cc @loujaybee

Next steps could include:

  1. Dropping the table header
  2. Removing the joined date information and move that to an audit log
  3. Move the role switch to the context menu to avoid accidental changes and arrow element repetition
Summary generated by Copilot

🤖 Generated by Copilot at 23ef648

Improved the organization dashboard UI and added a role filter feature. The changes in Members.tsx enhance the user experience and clarity of managing team members and their permissions.

BEFORE AFTER
Screenshot 2023-08-10 at 11 45 47 (2) Screenshot 2023-08-10 at 12 01 34 (2)

Related Issue(s)

Fixes #

How to test

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@mustard-mh
Copy link
Contributor

mustard-mh commented Aug 10, 2023

UX LGTM, but our logic of loading is incorrect it should show only when we're fetching data.

Right now it will show loading when there's no one in the list, and if I'm the only owner filter with members, it will show loading

{filteredMembers.length === 0 ? (

image

@gtsiolis
Copy link
Contributor Author

Ah, nice catch, @mustard-mh. ⚾

We did replace that part in #16417 to avoid showing the No members found message during load time, as we do with other pages like access tokens, etc.

Could you approve to merge this as the described issue is unrelated to the changes here and already existed before the changes? 🏓

I've opened EXP-419 to keep track of this.

Copy link
Contributor

@mustard-mh mustard-mh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roboquat roboquat merged commit 03b97d9 into main Aug 10, 2023
@roboquat roboquat deleted the gt/improve-org-members-filter branch August 10, 2023 15:10
@gtsiolis
Copy link
Contributor Author

Thanks, @mustard-mh! 🌮

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants