[UI] Dark Mode: Border for Type Dropdown #18554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, wondering why border colors on dropdown components are inconsistent. Is it intentional?
🏓 cc: @gtsiolis |
gtsiolis
approved these changes
Aug 21, 2023
There was a problem hiding this comment.
Nice catch! ⚾
Thanks for noticing, @Siddhant-K-code. 🌔
Regarding the border color inconsistency mentioned above, this is a matter of when we decide to create reusable components for each element. For now, utility classes help us not worry much about this, as these issues are trivial to fix ad-hoc, and provides the room and flexibility for evolving the components. ➿
|
/unhold |
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary generated by Copilot
🤖 Generated by Copilot at 3a830c4
Improve dark mode styling for team members dropdown. Add a darker border class to the
divelement inMembers.tsx.Related Issue(s)
followup fix for #18480
How to test
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold