Skip to content

[fga] WorkspaceService: workspace timeout + classes + git status (misc I) #18535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

geropl
Copy link
Member

@geropl geropl commented Aug 17, 2023

Description

Ticks the FGA boxes for the following methods:

  • setWorkspaceTimeout(workspaceId: string, duration: WorkspaceTimeoutDuration)
  • getWorkspaceTimeout(workspaceId: string)
  • maySetTimeout()
  • getSupportedWorkspaceClasses()
  • updateGitStatus(workspaceId: string, status: Required | undefined)[ ]
Summary generated by Copilot

🤖 Generated by Copilot at da8ecba

Refactored the server component to use a common service for workspace operations and added new features and tests for workspace classes and timeout.

Related Issue(s)

Parts of EXP-207

How to test

  • signup as regular user, and enable centraliedPermissions for your userID on ConfigCat
  • start a workspace, and try to configre a workspace timeout: is denied ✔️
  • create an org, and setup billing
  • start a new workspace in that org (!), and try to set the workspace timeout ✔️
  • create a file to change the git state and reload the dashboard. See how the git status has been updated ✔️

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

Copy link
Member

@svenefftinge svenefftinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@geropl
Copy link
Member Author

geropl commented Aug 17, 2023

/unhold

@roboquat roboquat merged commit ebc0d20 into main Aug 17, 2023
@roboquat roboquat deleted the gpl/fga-ws-misc-1 branch August 17, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants