[WIP][fga] WorkspaceService: watchWorkspaceImageBuildLogsm getHeadlessLog, WorkspaceService.sendHeartBeat #18538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roboquat
added
do-not-merge/work-in-progress
do-not-merge/hold
size/L
size/XL
and removed
size/L
labels
geropl
changed the title
|
Can you rebase? It's not clear what changes belong to this PR. |
geropl
force-pushed
the
gpl/fga-ws-misc-2
branch
from
3425938 to
53c4631
Compare
Done. Not sure why it did not rebase automatically...? Due to the squash? |
svenefftinge
approved these changes
Aug 18, 2023
There was a problem hiding this comment.
I would have assumed the two log related methods would go into headless-log-service but it might not be so easy to draw the line between that and the workspace service, so let's go with this for now and see how we can improve this in future.
otherwise code LGTM
I was torn here as well. 👍 |
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ticks the FGA boxes for the following methods:
Summary generated by Copilot
🤖 Generated by Copilot at b55df37
Refactored headless log and workspace image build logic to use
WorkspaceServiceclass. Moved constants and types to appropriate modules. Simplified and deprecated old methods inGitpodServerImpl. Added tests forWorkspaceService.Related Issue(s)
Parts of EXP-207
Based on: #18535
How to test
await window._gp.gitpodService.server.sendHeartBeat("your-instance-id")✔️await window._gp.gitpodService.server.sendHeartBeat("same-instance-id"): should fail withError: Workspace xyz not found.✔️Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold