[spicedb] fix stale connection handling #18607
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenefftinge
force-pushed
the
se/spicedb-cons
branch
from
1bc6b86 to
dadf7c6
Compare
svenefftinge
commented
Aug 27, 2023
svenefftinge
commented
Aug 27, 2023
svenefftinge
commented
Aug 27, 2023
svenefftinge
commented
Aug 27, 2023
svenefftinge
force-pushed
the
se/spicedb-cons
branch
from
dadf7c6 to
4a7e71d
Compare
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: @grpc/[email protected] |
Furisto
approved these changes
Aug 28, 2023
geropl
reviewed
Aug 29, 2023
|
Short update: I was testing before lunch, and constantly getting stuck in "wont' reload" (in the gRPC traces it looked as if it got stuck completely on the connection level), or having to wait for at least 30s until anything happens. |
|
oops sorry, I was redeploying a config change. I'll keep my hands off now. |
Good now, have my own playground. 👍 |
svenefftinge
force-pushed
the
se/spicedb-cons
branch
3 times, most recently
from
9c0421a to
d6626e9
Compare
svenefftinge
force-pushed
the
se/spicedb-cons
branch
from
d6626e9 to
fb75aa5
Compare
|
closed in favor of #18631 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary generated by Copilot
🤖 Generated by Copilot at 1bc6b86
This pull request refactors and improves the SpiceDB integration in the server component. It simplifies the code for creating and using the SpiceDB client, handles connection issues better, and adds metrics collection for the client calls. It affects the files
spicedb-authorizer.ts,spicedb.ts, andcontainer-module.ts.Related Issue(s)
Fixes EXP-379
Fixes EXP-292
How to test
serverthere should be (almost) no logs of[spicedb] Lost connection to SpiceDB - reconnecting...kubectl rollout restart deployment/spicedband keep using the dashboard of the preview env. You should (barely) see an effect, but in the logs you'll see a few entries of the message above ☝️ .Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold