-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[spicedb] fix stale connection handling #18631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: @grpc/[email protected] |
14 tasks
geropl
reviewed
Sep 1, 2023
geropl
reviewed
Sep 1, 2023
geropl
reviewed
Sep 1, 2023
fb75aa5
to
9abb902
Compare
geropl
approved these changes
Sep 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's see how this works out with more load. ✔️
/unhold |
easyCZ
approved these changes
Sep 1, 2023
Furisto
approved these changes
Sep 1, 2023
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary generated by Copilot
🤖 Generated by Copilot at 1bc6b86
This pull request refactors and improves the SpiceDB integration in the server component. It simplifies the code for creating and using the SpiceDB client, handles connection issues better, and adds metrics collection for the client calls. It affects the files
spicedb-authorizer.ts
,spicedb.ts
, andcontainer-module.ts
.Related Issue(s)
Fixes EXP-379
Fixes EXP-292
How to test
server
there should be (almost) no logs of[spicedb] Lost connection to SpiceDB - reconnecting...
kubectl rollout restart deployment/spicedb
and keep using the dashboard of the preview env. You should (barely) see an effect, but in the logs you'll see a few entries of the message above ☝️ .Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-test
Publish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/preview
If enabled this will create the environment on GCE infra
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh
. If enabled,with-preview
andwith-large-vm
will be enabled./hold