Skip to content

[spicedb] fix stale connection handling #18631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2023
Merged

[spicedb] fix stale connection handling #18631

merged 1 commit into from
Sep 1, 2023

Conversation

svenefftinge
Copy link
Contributor

Description

  • Fixes connection closes on connections that were about to connect (see comment).
  • Simplifies the writing up of the spicedb client povider
  • reuse the GRPC connection options we use elsewhere for spicedb
  • connects the metrics interceptor with the GRPC client connection
Summary generated by Copilot

🤖 Generated by Copilot at 1bc6b86

This pull request refactors and improves the SpiceDB integration in the server component. It simplifies the code for creating and using the SpiceDB client, handles connection issues better, and adds metrics collection for the client calls. It affects the files spicedb-authorizer.ts, spicedb.ts, and container-module.ts.

Related Issue(s)

Fixes EXP-379
Fixes EXP-292

How to test

  • use the preview env and check the logs of server there should be (almost) no logs of [spicedb] Lost connection to SpiceDB - reconnecting...
  • run kubectl rollout restart deployment/spicedb and keep using the dashboard of the preview env. You should (barely) see an effect, but in the logs you'll see a few entries of the message above ☝️ .

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@socket-security
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@types/long 4.0.0 None +0 12 kB types

🚮 Removed packages: @grpc/[email protected]

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see how this works out with more load. ✔️

@svenefftinge
Copy link
Contributor Author

/unhold

@svenefftinge
Copy link
Contributor Author

/unhold

@roboquat roboquat merged commit 841b616 into main Sep 1, 2023
@roboquat roboquat deleted the se/spice-conn branch September 1, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants