[ws-manager-api] Remove deprecated ide-related fields #18641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
geropl
force-pushed
the
gpl/ws-starter
branch
from
e45870a to
c94c4ad
Compare
geropl
force-pushed
the
gpl/ws-starter
branch
from
c94c4ad to
ac771ab
Compare
WVerlaek
approved these changes
Sep 1, 2023
There was a problem hiding this comment.
lgtm, triggered a run of the workspace integration tests: https://github.com/gitpod-io/gitpod/actions/runs/6047970199?pr=18641
Furisto
approved these changes
Sep 1, 2023
geropl
force-pushed
the
gpl/ws-starter
branch
from
ac771ab to
15ab10f
Compare
|
lgtm, tests passed except two, but that was due to overlapping runs of the integration tests in the same env. I can see if I can fix that by adding a concurrency group edit: #18643 |
geropl
force-pushed
the
gpl/ws-starter
branch
from
15ab10f to
bd3a5a7
Compare
svenefftinge
approved these changes
Sep 1, 2023
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cleanup of deprecated ide-related fields in ws-manager-api. All fields aren't used anymore.
Summary generated by Copilot
🤖 Generated by Copilot at e45870a
This pull request removes some deprecated and unused fields related to IDE images from the
core.protofile and the corresponding TypeScript and server code. This is to simplify the code and avoid potential compatibility issues.Related Issue(s)
Related: EXP-549
How to test
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold