Skip to content

[dashboard] remove vscode SSH warning #18654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2023
Merged

[dashboard] remove vscode SSH warning #18654

merged 1 commit into from
Sep 4, 2023

Conversation

svenefftinge
Copy link
Member

@svenefftinge svenefftinge commented Sep 4, 2023

Description

Removes the warnig around add ean entry to user's SSH config when using VS Code desktop

Summary generated by Copilot

🤖 Generated by Copilot at 6556efc

Removed local SSH proxy code from CreateWorkspacePage.tsx. Simplified the UI and logic for creating workspaces.

Related Issue(s)

Fixes #

How to test

Documentation

Preview status

gitpod:summary

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM ✔️

I got no context on this change, so can't provide other feedback.

@roboquat roboquat merged commit 292aefb into main Sep 4, 2023
@roboquat roboquat deleted the se/no-ssh-warn branch September 4, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants