Skip to content

[dashboard] remove vscode SSH warning #18654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2023
Merged

[dashboard] remove vscode SSH warning #18654

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 0 additions & 36 deletions components/dashboard/src/workspaces/CreateWorkspacePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ import { useDirtyState } from "../hooks/use-dirty-state";
import { LinkButton } from "../components/LinkButton";
import { InputField } from "../components/forms/InputField";
import Alert from "../components/Alert";
import { useFeatureFlag } from "../data/featureflag-query";

export function CreateWorkspacePage() {
const { user, setUser } = useContext(UserContext);
Expand Down Expand Up @@ -419,7 +418,6 @@ export function CreateWorkspacePage() {
</Button>
</div>

{selectedIde === "code-desktop" && <LocalSSHWarning className="mx-6 mt-3 rounded-lg overflow-hidden" />}
{workspaceContext.data && (
<RememberOptions
disabled={workspaceContext.isLoading || createWorkspaceMutation.isStarting}
Expand Down Expand Up @@ -448,40 +446,6 @@ export function CreateWorkspacePage() {
);
}

function LocalSSHWarning(props: { className: string }) {
const isLocalSSHProxyEnabled = useFeatureFlag("gitpod_desktop_use_local_ssh_proxy");

if (!isLocalSSHProxyEnabled) {
return null;
}

return (
<div className={props.className}>
<Alert light className="bg-gray-100 dark:bg-gray-800" type="info">
Choosing VS Code for Desktop will add a single entry to your local SSH configuration. Gitpod won't
interfere with your existing SSH configurations.&nbsp;
<a
className="gp-link"
href="https://www.gitpod.io/docs/references/ides-and-editors/vscode#connecting-to-vs-code-desktop"
target="_blank"
rel="noreferrer"
>
Learn more
</a>
&nbsp;&middot;&nbsp;
<a
className="gp-link"
href="https://github.com/gitpod-io/gitpod/issues/18109"
target="_blank"
rel="noreferrer"
>
Send feedback
</a>
</Alert>
</div>
);
}

function RememberOptions(params: { disabled?: boolean; checked: boolean; onChange: (checked: boolean) => void }) {
const { disabled, checked, onChange } = params;

Expand Down