node grpc spike dashboard to server #18691

akosyakov · 2023-09-11T07:08:45Z

Description

Summary generated by Copilot

`🤖 Generated by Copilot at c251d76`

This pull request adds new files that define and generate code for a dummy service for reliability testing using various protobuf and connect libraries. The files include a protobuf file, go files for grpc and connect-go clients and servers, and typescript files for connect-web clients and messages.

Related Issue(s)

Fixes EXP-571

How to test

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

🏷️ Name - ak-node-grpc
🔗 URL - ak-node-grpc.preview.gitpod-dev.com/workspaces.
📚 Documentation - See our internal documentation for information on how to interact with your preview environment.
📦 Version - ak-node_grpc-gha.16710
🗒️ Logs - GCP Logs Explorer

Build Options

Build

/werft with-werft
Run the build with werft instead of GHA
leeway-no-cache
/werft no-test
Run Leeway with --dont-test

Publish

/werft publish-to-npm
/werft publish-to-jb-marketplace

Installer

analytics=segment
with-dedicated-emulation
workspace-feature-flags
Add desired feature flags to the end of the line above, space separated

Preview Environment / Integration Tests

/werft with-local-preview
If enabled this will build install/preview
/werft with-preview
/werft with-large-vm
/werft with-gce-vm
If enabled this will create the environment on GCE infra
with-integration-tests=all
Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
with-monitoring

/hold

socket-security · 2023-09-12T12:01:30Z

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages	Version	New capabilities	Transitives	Size	Publisher
@bufbuild/connect-web	0.2.1...0.13.0	None	`+2/-0`	1.49 MB	tstamm-buf
@bufbuild/connect-express	0.8.1...0.13.0	None	`+4/-4`	2.2 MB	tstamm-buf
@bufbuild/connect	0.8.1...0.13.0	None	`+0/-0`	717 kB	tstamm-buf

akosyakov · 2023-09-14T10:21:55Z

components/server/src/session-handler.ts

-
-            // Trigger the next middleware in the chain.
-            next();
+            return await this.userService.findUserById(subject, subject);
        } catch (err) {
            log.warn("Failed to authenticate user with JWT Session", err);


not sure here, maybe we should call next with err, but maybe not

This PR did not change the semantic though. Pleas review for it 🙏

components/gitpod-protocol/src/experiments/types.ts

components/dashboard/src/service/metrics.ts

components/public-api/typescript/src/metrics.ts

akosyakov · 2023-09-14T11:46:36Z

components/public-api/typescript/src/metrics.ts

+}
+
+export class MetricsReporter {
+    private static readonly REPORT_INTERVAL = 10000;


we can increase it to 1 min and instead do a final flush with https://developer.mozilla.org/en-US/docs/Web/API/Navigator/sendBeacon if it turns out to be a problem later

geropl · 2023-09-14T13:53:15Z

Starting to review now.

components/dashboard/src/service/service.tsx

geropl · 2023-09-14T14:27:31Z

components/server/src/api/server.ts

+                },
+            }),
+        );
+        // TODO(al) cover unhandled cases


geropl · 2023-09-14T14:31:43Z

components/server/src/api/server.ts

+
+                    const context = args[1] as HandlerContext;
+                    async function call<T>(): Promise<T> {
+                        const user = await self.verify(context);


nit: As discussed IMO we could pull this (and some of the metrics here) into middleware. But not a priority for this PR.

components/server/src/container-module.ts

components/dashboard/src/service/metrics.ts

geropl · 2023-09-14T15:15:02Z

FYI: Added this rule to the feature flag:

geropl · 2023-09-14T16:02:56Z

For some reason I never see any Hello RPC method triggered... metrics work fine though. 🤔 I wonder whether that feature flag evaluates to true....

components/dashboard/src/service/service.tsx

geropl

Code LGTM, tested and works. ✔️

Was just tired yesterday 😅

Two small nits: https://github.com/gitpod-io/gitpod/pull/18691/files#r1326861983

akosyakov · 2023-09-15T11:46:21Z

/unhold

roboquat added do-not-merge/work-in-progress do-not-merge/hold size/L size/XL size/XXL and removed size/L size/XL labels Sep 11, 2023

akosyakov force-pushed the ak/node_grpc branch from 7d7f55d to f4c1eaa Compare September 12, 2023 11:55

akosyakov force-pushed the ak/node_grpc branch from 1051a69 to 5565cd8 Compare September 13, 2023 16:14

akosyakov added 20 commits September 14, 2023 07:42

[public-api] add dummy service for testing

9a1447e

[public-api] proxy dummy to server

e407294

[public-api] hello service server impl

9e7af6a

[server] fix API contribution bindings

aec5e22

[dashboard] emulate unary call

99b3799

only if actually called

20116a4

[dummy] auth

04f1390

fix tests

d7be37d

[server] add interceptor to public api

d882137

add server side observability

0dbbe52

fix port name

14a2a94

change to unimplemented for unknown methods

6eead8e

[public-api] client metrics

6abcc26

fix metrics imports

9ee89d6

align server metrics

42988ef

actually fix metrics

49bdf1e

add feature flags

a5ce840

fix server side streams

88d7b8f

[dashboard] hook error reporting

b8f3ec1

rebase and fix imports

e1bc2a9

akosyakov commented Sep 14, 2023

View reviewed changes

components/gitpod-protocol/src/experiments/types.ts Outdated Show resolved Hide resolved

akosyakov commented Sep 14, 2023

View reviewed changes

components/dashboard/src/service/metrics.ts Show resolved Hide resolved

akosyakov commented Sep 14, 2023

View reviewed changes

components/public-api/typescript/src/metrics.ts Outdated Show resolved Hide resolved

feature flagged metrics from dashboard

246cf76

akosyakov changed the title ~~node grpc~~ node grpc spike dashboard to server Sep 14, 2023

akosyakov marked this pull request as ready for review September 14, 2023 11:42

akosyakov requested a review from a team as a code owner September 14, 2023 11:42

roboquat removed the do-not-merge/work-in-progress label Sep 14, 2023

akosyakov requested a review from geropl September 14, 2023 11:42

github-actions bot added the team: team-experience label Sep 14, 2023

akosyakov commented Sep 14, 2023

View reviewed changes

revert GRPC_TYPE

9dc74c1

geropl reviewed Sep 14, 2023

View reviewed changes

components/dashboard/src/service/service.tsx Outdated Show resolved Hide resolved

geropl reviewed Sep 14, 2023

View reviewed changes

components/server/src/api/server.ts

},

}),

);

// TODO(al) cover unhandled cases

Copy link

Member

geropl Sep 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

geropl reviewed Sep 14, 2023

View reviewed changes

components/server/src/container-module.ts Outdated Show resolved Hide resolved

geropl reviewed Sep 14, 2023

View reviewed changes

components/dashboard/src/service/metrics.ts Show resolved Hide resolved

geropl reviewed Sep 15, 2023

View reviewed changes

components/dashboard/src/service/service.tsx Outdated Show resolved Hide resolved

geropl reviewed Sep 15, 2023

View reviewed changes

components/dashboard/src/service/service.tsx Outdated Show resolved Hide resolved

geropl approved these changes Sep 15, 2023

View reviewed changes

address feedback

400fc32

roboquat removed the do-not-merge/hold label Sep 15, 2023

roboquat merged commit 352484b into main Sep 15, 2023

roboquat deleted the ak/node_grpc branch September 15, 2023 11:46

akosyakov mentioned this pull request Sep 15, 2023

[dashboard] unify error reporting #18726

Merged

14 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

node grpc spike dashboard to server #18691

node grpc spike dashboard to server #18691

Uh oh!

akosyakov commented Sep 11, 2023 •

edited

Loading

Uh oh!

socket-security bot commented Sep 12, 2023

Uh oh!

akosyakov Sep 14, 2023

Uh oh!

akosyakov Sep 14, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

akosyakov Sep 14, 2023

Uh oh!

geropl commented Sep 14, 2023

Uh oh!

Uh oh!

geropl Sep 14, 2023

Uh oh!

geropl Sep 14, 2023

Uh oh!

Uh oh!

Uh oh!

geropl commented Sep 14, 2023

Uh oh!

geropl commented Sep 14, 2023

Uh oh!

Uh oh!

Uh oh!

geropl left a comment

Uh oh!

akosyakov commented Sep 15, 2023

Uh oh!

Uh oh!

node grpc spike dashboard to server #18691

node grpc spike dashboard to server #18691

Uh oh!

Conversation

akosyakov commented Sep 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

🤖 Generated by Copilot at c251d76

Related Issue(s)

How to test

Documentation

Preview status

Build Options

Uh oh!

socket-security bot commented Sep 12, 2023

Uh oh!

akosyakov Sep 14, 2023

Choose a reason for hiding this comment

Uh oh!

akosyakov Sep 14, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

akosyakov Sep 14, 2023

Choose a reason for hiding this comment

Uh oh!

geropl commented Sep 14, 2023

Uh oh!

Uh oh!

geropl Sep 14, 2023

Choose a reason for hiding this comment

Uh oh!

geropl Sep 14, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

geropl commented Sep 14, 2023

Uh oh!

geropl commented Sep 14, 2023

Uh oh!

Uh oh!

Uh oh!

geropl left a comment

Choose a reason for hiding this comment

Uh oh!

akosyakov commented Sep 15, 2023

Uh oh!

Uh oh!

akosyakov commented Sep 11, 2023 •

edited

Loading

`🤖 Generated by Copilot at c251d76`