[dashboard] unify error reporting #18726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akosyakov
force-pushed
the
ak/dashboard_unify_error_reporting
branch
from
a59a371 to
3e21102
Compare
move error boundary to general error reporting endpoint as well
akosyakov
force-pushed
the
ak/dashboard_unify_error_reporting
branch
from
3e21102 to
773444c
Compare
akosyakov
commented
Sep 15, 2023
| // Cap message and url length so the entries aren't of unbounded length | ||
| log.warn("dashboard error boundary", { | ||
| message: (message || "").substring(0, 200), | ||
| url: (url || "").substring(0, 200), |
There was a problem hiding this comment.
it was leaking sensitive data in some URLs
akosyakov
commented
Sep 15, 2023
| @@ -264,15 +263,6 @@ export function observeSpicedbClientLatency(operation: string, outcome: Error | | |||
| ); | |||
| } | |||
|
|
|||
| export const dashboardErrorBoundary = new prometheusClient.Counter({ | |||
There was a problem hiding this comment.
it is already available in GCP if one search for the message
akosyakov
commented
Sep 15, 2023
akosyakov
commented
Sep 15, 2023
|
Code LGTM, waiting for a preview env... |
geropl
approved these changes
Sep 18, 2023
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #18691 we moved to dashboard to use metrics endpoint used already by other clients to collect client observability metrics and errors. This PR is a follow up to clean up other places where custom code was used.
Summary generated by Copilot
🤖 Generated by Copilot at a59a371
Improved error reporting for dashboard error boundaries and deprecated server-side method. Refactored
reportErrorfunction and fixed a bug inmetrics.ts.Related Issue(s)
Fixes #
How to test
new Promise((_,reject) => reject(new Error("foobar")))in devtoolreportErroris called with all necessary info including user id from network tab.Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold