Skip to content

[server] Tone down log messages on startWorkspace #18720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Conversation

geropl
Copy link
Member

@geropl geropl commented Sep 15, 2023

Description

Summary generated by Copilot

🤖 Generated by Copilot at 5afea4a

Improve logging of workspace instance start operations in workspace-starter.ts. Use a new type to mark safe values and provide more details on errors.

Related Issue(s)

Fixes EXP-605

How to test

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@roboquat roboquat added size/S and removed size/XS labels Sep 15, 2023
@geropl geropl marked this pull request as ready for review September 15, 2023 08:14
@geropl geropl requested a review from a team as a code owner September 15, 2023 08:14
Copy link
Member

@AlexTugarev AlexTugarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@geropl
Copy link
Member Author

geropl commented Sep 15, 2023

/unhold

@roboquat roboquat merged commit 7fa1b2d into main Sep 15, 2023
@roboquat roboquat deleted the gpl/605-tone-down branch September 15, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants