[content-service] log duration for s3 download and tar extract #18829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DirectDownloader interface does not differentiate between downloading and extract tarbal...when youdownload, you also extract. https://github.com/gitpod-io/gitpod/blob/9a38b607055780fa7b2cd61c1379143d6c7b3715/components/content-service/pkg/storage/storage.go#L133 In the context of a prebuild initializer: https://github.com/gitpod-io/gitpod/blob/9a38b607055780fa7b2cd61c1379143d6c7b3715/components/content-service/pkg/initializer/prebuild.go#L69 When we Run, we do DownloadSnapshot: https://github.com/gitpod-io/gitpod/blob/9a38b607055780fa7b2cd61c1379143d6c7b3715/components/content-service/pkg/initializer/snapshot.go#L48 It does both operations: https://github.com/gitpod-io/gitpod/blob/9a38b607055780fa7b2cd61c1379143d6c7b3715/components/content-service/pkg/storage/s3.go#L290 Supervisor, which records initializer metrics, reads them from /workspace/.gitpod/ready file: https://github.com/gitpod-io/gitpod/blob/55414729fab00fa23888c1868579425907518a68/components/supervisor/pkg/supervisor/supervisor.go#L1639
aledbf
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add logging to help understand how long it takes to download and extract files. Also, fix a scenario where the download is not found, so we properly inform upstream consumers.
Summary generated by Copilot
🤖 Generated by Copilot at a6beb51
Improved logging and error handling for S3 storage in
content-service. Fixed a download retry bug ins3.go.Related Issue(s)
Fixes ENG-884
How to test
n/a
Documentation
Preview status
gitpod:summary
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold