Skip to content

[content-service] remove s5cmd integration #18863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 3, 2023
Merged

Conversation

kylos101
Copy link
Contributor

@kylos101 kylos101 commented Oct 3, 2023

Description

Revert s5cmd changes for content-service and ws-daemon, they weren't being used as part of content-initialization, we were still using aria2c.

Also, add logging to ws-daemon, so we can see duration for download and tarball extraction.

Additionally, we cannot use s5cmd as an alternative aria2c. This is because ws-daemon expects a presigned URL, and s5cmd works with S3 URI and AWS credential.

Summary generated by Copilot

🤖 Generated by Copilot at 8cab5c9

Replaced s5cmd with s3manager for S3 storage operations in content-service and ws-daemon. Added logging and timing metrics to the workspace content download function in ws-daemon.

Related Issue(s)

Related to ENG-884

How to test

Documentation

Preview status

gitpod:summary

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@roboquat roboquat merged commit 67c2800 into main Oct 3, 2023
@roboquat roboquat deleted the kylos101/init-duration branch October 3, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants