[content-service] remove s5cmd integration #18863
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Revert s5cmd changes for content-service and ws-daemon, they weren't being used as part of content-initialization, we were still using aria2c.
Also, add logging to ws-daemon, so we can see duration for download and tarball extraction.
Additionally, we cannot use s5cmd as an alternative aria2c. This is because ws-daemon expects a presigned URL, and s5cmd works with S3 URI and AWS credential.
Summary generated by Copilot
🤖 Generated by Copilot at 8cab5c9
Replaced
s5cmd
withs3manager
for S3 storage operations incontent-service
andws-daemon
. Added logging and timing metrics to the workspace content download function inws-daemon
.Related Issue(s)
Related to ENG-884
How to test
Documentation
Preview status
gitpod:summary
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-test
Publish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/preview
If enabled this will create the environment on GCE infra
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh
. If enabled,with-preview
andwith-large-vm
will be enabled./hold