Setup data loading for repos list #18935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
filiptronicek
approved these changes
Oct 17, 2023
| project: Project; | ||
| }; | ||
| export const RepositoryListItem: FC<Props> = ({ project }) => { | ||
| const url = usePrettyRepoURL(project.cloneUrl); |
There was a problem hiding this comment.
We could potentially change this to omit the scheme in the future, as I don't think it makes much of a difference with all of them being http/https.
There was a problem hiding this comment.
Good call, I'll def do that in a followup, mostly an oversight 😄
14 tasks
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This sets up basics to load the first page of configured repositories (projects) and lists them w/ links to their respective detail pages. This is all behind a flag still and is meant to enable followup/adjacent work.
This isn't intended to match our design target, just unlock some functionality and get data on the UI.
useListProjectsQuerytouseListAllProjectsQueryas that's what it was doing.useListProjectsQuerythat loads a single page of projects instead.@podkitalias for thesrc/components/podkitfoldercn()helper to assist in merging tailwind classNames (as suggested here in shadcn)<Text>and<TextMuted>component to encapsulate text colors & dark mode (I'm not sure if this is the best way to go about this yet, but wanted to start w/ it).Summary generated by Copilot
🤖 Generated by Copilot at 48f8c15
Added a new query hook and component for listing all projects without pagination, and updated existing components to use either the new or the old query hook depending on the context. This improves the performance and usability of the dashboard for creating and managing projects and their repositories. The affected files are
create-project-mutation.ts,project-context.tsx,Projects.tsx,ProjectSettings.tsx,CreateWorkspacePage.tsx,list-all-projects-query.ts,list-projects-query.ts, andRepositoryList.tsx.Related Issue(s)
Fixes EXP-795 & EXP-802 & EXP-796
How to test
/repositoriesand verify your project you created is listed./repositories/:id(data not loaded there yet, verify url)Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold