Adding name form to repository config detail page #18943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/unhold |
selfcontained
force-pushed
the
brad/repository-detail-name
branch
from
e1026d5 to
dc9b33f
Compare
|
/hold |
selfcontained
commented
Oct 18, 2023
There was a problem hiding this comment.
moved this into the project-queries file - feels kind nice having related queries co-located so thought I’d give it a try.
filiptronicek
approved these changes
Oct 18, 2023
| const updateProject = useUpdateProject(); | ||
| const [projectName, setProjectName] = useState(project.name); | ||
|
|
||
| const nameError = useOnBlurError("Sorry, this name is too long.", projectName.length <= 32); |
There was a problem hiding this comment.
It may be good to trim the name here to make sure we are not counting trailing or leading white spaces as part of the limit. I think we should do this in the mutation too – there is another bug in there with these pesky characters.
There was a problem hiding this comment.
I’ll plan on handling this in a follow up (or feel free to while I’m out).
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Getting some foundation pieces in there for the repository config detail page. We need to build a get project by id api endpoint, so I have this stubbed in an innefficient way that loads all projects and finds the match from there to temporarily unblock building out some of this UI.
I've added the form to update the name as well to get some functionality stubbed out as well there.
Summary generated by Copilot
🤖 Generated by Copilot at 3ea4b4f
This pull request introduces projects as a new concept for configuring repositories in teams or organizations. It adds custom hooks and form components to fetch and update project data from the public API, and improves the UI of the
RepositoryDetailcomponent.Related Issue(s)
How to test
/repositories/:id/projects/:id/settings, and then manually update the url.Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold