Skip to content

Revert Refine workspace and fix bugs #19178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 4, 2023
Merged

Revert Refine workspace and fix bugs #19178

merged 9 commits into from
Dec 4, 2023

Conversation

mustard-mh
Copy link
Contributor

@mustard-mh mustard-mh commented Dec 1, 2023

Description

Summary generated by Copilot

🤖[deprecated] Generated by Copilot at 175f3b1

This pull request updates the dashboard and the public API components to use the new workspace model, which has nested fields for spec, metadata, and source. It also adds new RPCs and methods for updating and parsing the workspace metadata and spec, and simplifies the environment variable API. It modifies several TypeScript, Go, and proto files, and adjusts the cache version and the end-of-file-fixer command.

Related Issue(s)

Fixes #

How to test

Previous steps

See description of #19138

With Feature Flag enabled and disabled

Fix validate

  • Open preview env, exec code below in DevTool Console
const user = await _gp.gitpodService.server.getLoggedInUser();
user.additionalData.ideSettings.defaultIde = undefined
await _gp.gitpodService.server.updateLoggedInUser(user);
  • Refresh, check DevTools -> Network -> WS -> gitpod -> getLoggedInUser respond with editor undefined
  • It should be able to start workspaces

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

Copy link
Member

@svenefftinge svenefftinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've verified the listed testing steps

@roboquat roboquat merged commit 39ebf1d into main Dec 4, 2023
@roboquat roboquat deleted the hw/papi-refine-ws branch December 4, 2023 10:36
* `Duration.nanos` is ignored
* @returns a string like "1h2m3s", valid time units are `s`, `m`, `h`
*/
toDurationString(duration: PartialMessage<Duration>): string {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @AlexTugarev it seems there are already some convertions for durations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants