Skip to content

Revert "Redirect on workspace stop" #19323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2024
Merged

Revert "Redirect on workspace stop" #19323

merged 1 commit into from
Jan 15, 2024

Conversation

svenefftinge
Copy link
Member

@svenefftinge svenefftinge commented Jan 15, 2024 •
edited by github-actions bot
Loading

Preview status

Gitpod was successfully deployed to your preview environment.

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

@svenefftinge svenefftinge requested a review from a team as a code owner January 15, 2024 09:12
@linear Linear
Copy link

linear bot commented Jan 15, 2024

Issue reopened: EXP-1082 Allow Redirect Workspace on Stopping

@svenefftinge
Copy link
Member Author

/hold

@svenefftinge
Copy link
Member Author

svenefftinge commented Jan 15, 2024 •
edited by github-actions bot
Loading

/gh run recreate-vm=true

Comment triggered a workflow run

Started workflow run: 7526865373

  • recreate_vm: true

@svenefftinge
Copy link
Member Author

/unhold

@roboquat roboquat merged commit 827a1a0 into main Jan 15, 2024
@roboquat roboquat deleted the revert-19314-jp/relaxed-canidae branch January 15, 2024 09:46
jeanp413 added a commit that referenced this pull request Jan 15, 2024
@jeanp413
Revert "Revert "Redirect on workspace stop" (#19323)"
f9720e0 
This reverts commit 827a1a0.
roboquat pushed a commit that referenced this pull request Jan 17, 2024
@jeanp413
Revert "Revert "Redirect on workspace stop" (#19323)" (#19325)
e6bf79e 
* Revert "Revert "Redirect on workspace stop" (#19323)"

This reverts commit 827a1a0.

* Fix

* Fix

* 💄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akosyakov akosyakov akosyakov approved these changes

Assignees
No one assigned
Labels
size/M team: team-experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@svenefftinge @akosyakov @roboquat