Skip to content

Revert "Revert "Redirect on workspace stop" (#19323)" #19325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 17, 2024
Merged

Conversation

jeanp413
Copy link
Member

@jeanp413 jeanp413 commented Jan 15, 2024

This reverts commit 827a1a0 with a proper fix

Description

Related Issue(s)

Fixes https://linear.app/gitpod/issue/EXP-1082

How to test

Web editor

  1. Select default editor to vscode web
  2. Start workspace
  3. Stop workspace, it should redirect automatically to the context url or a custom url from configcat

Desktop editor

  1. Select a desktop editor
  2. Start workspace, check buttons work
  3. Stop workspace, check buttons work

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@jeanp413 jeanp413 marked this pull request as ready for review January 15, 2024 18:27
@jeanp413 jeanp413 requested a review from a team as a code owner January 15, 2024 18:27
@jeanp413
Copy link
Member Author

cc @svenefftinge

@jeanp413 jeanp413 requested a review from svenefftinge January 16, 2024 16:19
Copy link
Member

@svenefftinge svenefftinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven'T tested because the preview env was no longer running, but I assume you testet it.

Copy link
Contributor

@mustard-mh mustard-mh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in preview env, it's working well. But will replace configured url's search params

example: https://google.com/AA?a=1

Copy link
Contributor

@mustard-mh mustard-mh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve to unblock,

@roboquat roboquat merged commit e6bf79e into main Jan 17, 2024
@roboquat roboquat deleted the jp/retired-snake branch January 17, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants