[dashboard] allow no expiration date PAT #19327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
mustard-mh
force-pushed
the
hw/forever-pat-2
branch
from
0b95c69 to
f73b20f
Compare
mustard-mh
changed the title
mustard-mh
force-pushed
the
hw/forever-pat-2
branch
from
28984fb to
3f7fad2
Compare
| getDate: () => dayjs().add(d, "days").toDate(), | ||
| })); | ||
|
|
||
| // Max value of timestamp(6) in mysql is 2038-01-19 03:14:17 |
There was a problem hiding this comment.
❤️ thanks for checking that
svenefftinge
approved these changes
Jan 17, 2024
mustard-mh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This feature only enabled with
dataopsFeature Flag enable (both API call and UX)UX Preview (mock 8 days forward), updates: show warning icon if token never expires + tooltip
Related Issue(s)
Relates EXP-1084
How to test
https://hw-forever-pat-2.preview.gitpod-dev.com/workspaces
With Feature Flag OFF
hw-prefix preview env and your userIDNo expirationoption when create / edit PATsWith Feature Flag ON
Need to enable dataops Feature Flag with your userID
✅ Share test results
Documentation
Preview status
gitpod:summary
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold