[db] add migration to alter pat table allow null expirationTime #19328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
| @@ -53,7 +53,7 @@ export class DBPersonalAccessToken { | |||
| scopes: string[]; | |||
|
|
|||
| @Column("datetime") | |||
| expirationTime: Date; | |||
| expirationTime: Date | null; | |||
There was a problem hiding this comment.
AFAIR we've really never used null as value. Wouldn't setting a date in distant future be less likely to cause problems?
There was a problem hiding this comment.
@svenefftinge So just add option to allow 5 years? And not show Never expires! but actual expiration date on dashboard?
There was a problem hiding this comment.
Or hard code something like 2099-01-01 00:00:00 as never expires
|
Close as we don't need to modify db #19328 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DB migration part of #19327, split in case we need to do revert / rollback
Related Issue(s)
Relates EXP-1084
How to test
Should be tested in #19327
Documentation
Preview status
gitpod:summary
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold