Skip to content

[code] Fix code dockerfile #20308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2024
Merged

[code] Fix code dockerfile #20308

merged 1 commit into from
Oct 19, 2024

Conversation

jeanp413
Copy link
Member

@jeanp413 jeanp413 commented Oct 18, 2024

Description

Fix code dockerfile for code nightly

How to test

Documentation

Preview status

gitpod:summary

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

Copy link
Member

@filiptronicek filiptronicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, workflow run passes

@roboquat roboquat merged commit 00b2a76 into main Oct 19, 2024
61 of 62 checks passed
@roboquat roboquat deleted the jp/extra-hare branch October 19, 2024 18:58
@mustard-mh
Copy link
Contributor

Seems vscode will publish new patch version for 1.94. We may need to make it another leeway.nightly.Dockerfile because this Dockerfile only works for Nightly (1.95) but changes will make leeway build stable code as well, see #20309.

@mustard-mh mustard-mh mentioned this pull request Oct 21, 2024
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants