Skip to content

Fix stable code build #20310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Fix stable code build #20310

merged 2 commits into from
Oct 21, 2024

Conversation

mustard-mh
Copy link
Contributor

@mustard-mh mustard-mh commented Oct 21, 2024

Description

Follow up for #20308 (comment) and internal chat

Related Issue(s)

Fixes #

How to test

No need, or you could compare the changes between code > leeway.Dockerfile and leeway.nightly.Dockerfile

Documentation

Preview status

gitpod:summary

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM as far as I can tell - let's see if they are working! ✔️

@roboquat roboquat merged commit 2fbbe5d into main Oct 21, 2024
35 of 38 checks passed
@roboquat roboquat deleted the hw/code-build branch October 21, 2024 08:24
@mustard-mh mustard-mh mentioned this pull request Oct 21, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants